zacharymorn commented on pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#issuecomment-761525653
> > I will try to find the issue tomorrow...! (not sure if I will have time, so if you can reproduce on Linux feel free to help out) > > Hmmm that's strange. On my macbook these tests are passing. > > <img alt="Screen Shot 2021-01-15 at 6 37 43 PM" width="511" src="https://user-images.githubusercontent.com/2986273/104795124-dc558080-5760-11eb-8a2d-98aa31a869a1.png";> > > I'll install Windows and Linux VMs over the weekend to further test them out. @uschindler I figured out the issue here. Apparently I introduced a bug on EOF handling when fixing the `BaseDirectoryTestCase#testSeekPastEOF` test failure (fixed one, broke another! :( ) The reason this bug was not uncovered when running the tests on Mac is, the EOF tests in question only failed when the file size being tested is a multiple of block size, which would eventually cause the condition `filePos == channel.size()` in `DirectIOIndexInput#refill` and an EOF exception would be thrown there explicitly. This is the case for Windows platform as the file size in tests is 1024, and the block size is 512; However, for Mac and some linux, the block size is 4096, so this particular EOF handling path was not encountered. I've added a new test to force this condition and pushed up the fix. The tests are passing on my Mac and Windows VM now, could you please take a look and see if it works for you as well? Sorry for the bug there! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
![https://user-images.githubusercontent.com/2986273/104795124-dc558080-5760-11eb-8a2d-98aa31a869a1.png"](https://user-images.githubusercontent.com/2986273/104795124-dc558080-5760-11eb-8a2d-98aa31a869a1.png"){kind=link}