epugh commented on pull request #1435: URL: https://github.com/apache/lucene-solr/pull/1435#issuecomment-761565236
It's encouraging that there doesn't seem to be a lot of change here, reusing most of what we have. Does this have any other ramifications on what it touches? I quickly looked at the `/solr/docker` dir in master, and that appears to start Solr in a different manner? Is there any reasonable way of having a test for this for the future? Lastly, this change, is there consensus on it? When I copied the Solr start up scripts over to the Tika project, I had read that systemd was the future, but since I knew the Solr ones, I modeled the Tika scripts on that. I ask partly because I need to test the start up scripts for Tika 2.0 soon ;-) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
