[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1109: More pervasive use of PackageLoader / PluginInfo

dsmiley commented on a change in pull request #1109: More pervasive use of PackageLoader / PluginInfo URL: https://github.com/apache/lucene-solr/pull/1109#discussion_r361586269 ## File path: solr/core/src/java/org/apache/solr/core/PluginBag.java ## @@ -140,11 +139,10 @@ pu

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1124: SOLR-14151 :Schema components to be loadable from packages

dsmiley commented on a change in pull request #1124: SOLR-14151 :Schema components to be loadable from packages URL: https://github.com/apache/lucene-solr/pull/1124#discussion_r361543380 ## File path: solr/core/src/java/org/apache/solr/core/ConfigSet.java ## @@ -51,8 +53,1

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1124: SOLR-14151 :Schema components to be loadable from packages

dsmiley commented on a change in pull request #1124: SOLR-14151 :Schema components to be loadable from packages URL: https://github.com/apache/lucene-solr/pull/1124#discussion_r361578602 ## File path: solr/core/src/java/org/apache/solr/core/SolrCore.java ## @@ -935,6 +945,

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1124: SOLR-14151 :Schema components to be loadable from packages

dsmiley commented on a change in pull request #1124: SOLR-14151 :Schema components to be loadable from packages URL: https://github.com/apache/lucene-solr/pull/1124#discussion_r361541789 ## File path: solr/core/src/java/org/apache/solr/core/ConfigSet.java ## @@ -28,17 +30,

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1124: SOLR-14151 :Schema components to be loadable from packages

dsmiley commented on a change in pull request #1124: SOLR-14151 :Schema components to be loadable from packages URL: https://github.com/apache/lucene-solr/pull/1124#discussion_r361578750 ## File path: solr/core/src/java/org/apache/solr/handler/SchemaHandler.java ## @@ -200

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1124: SOLR-14151 :Schema components to be loadable from packages

dsmiley commented on a change in pull request #1124: SOLR-14151 :Schema components to be loadable from packages URL: https://github.com/apache/lucene-solr/pull/1124#discussion_r361579553 ## File path: solr/core/src/java/org/apache/solr/pkg/PackageListeners.java ## @@ -75,1

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1124: SOLR-14151 :Schema components to be loadable from packages

dsmiley commented on a change in pull request #1124: SOLR-14151 :Schema components to be loadable from packages URL: https://github.com/apache/lucene-solr/pull/1124#discussion_r361542052 ## File path: solr/core/src/java/org/apache/solr/core/PluginInfo.java ## @@ -63,29 +63

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1124: SOLR-14151 :Schema components to be loadable from packages

dsmiley commented on a change in pull request #1124: SOLR-14151 :Schema components to be loadable from packages URL: https://github.com/apache/lucene-solr/pull/1124#discussion_r361543861 ## File path: solr/core/src/java/org/apache/solr/core/ConfigSet.java ## @@ -51,8 +53,1

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1124: SOLR-14151 :Schema components to be loadable from packages

dsmiley commented on a change in pull request #1124: SOLR-14151 :Schema components to be loadable from packages URL: https://github.com/apache/lucene-solr/pull/1124#discussion_r361542449 ## File path: solr/core/src/java/org/apache/solr/core/PluginLoader.java ## @@ -0,0 +1,

[jira] [Commented] (SOLR-14102) FacetModule use number of responses from shards as number of shards

[ https://issues.apache.org/jira/browse/SOLR-14102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17003833#comment-17003833 ] Tomohiro Manabe commented on SOLR-14102: Thanks for reviewing. I think we need a

[GitHub] [lucene-solr] noblepaul commented on issue #1109: More pervasive use of PackageLoader / PluginInfo

noblepaul commented on issue #1109: More pervasive use of PackageLoader / PluginInfo URL: https://github.com/apache/lucene-solr/pull/1109#issuecomment-569156544 > I like the 3 categories of plugins very much, and also especially glad and surprised to hear you state "Hot reloading is not im

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1123: LUCENE-9093: Unified highlighter with word separator never gives context to the left

dsmiley commented on a change in pull request #1123: LUCENE-9093: Unified highlighter with word separator never gives context to the left URL: https://github.com/apache/lucene-solr/pull/1123#discussion_r361541004 ## File path: lucene/highlighter/src/java/org/apache/lucene/search/uh

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1123: LUCENE-9093: Unified highlighter with word separator never gives context to the left

dsmiley commented on a change in pull request #1123: LUCENE-9093: Unified highlighter with word separator never gives context to the left URL: https://github.com/apache/lucene-solr/pull/1123#discussion_r361539250 ## File path: lucene/highlighter/src/java/org/apache/lucene/search/uh

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1123: LUCENE-9093: Unified highlighter with word separator never gives context to the left

dsmiley commented on a change in pull request #1123: LUCENE-9093: Unified highlighter with word separator never gives context to the left URL: https://github.com/apache/lucene-solr/pull/1123#discussion_r361538041 ## File path: lucene/highlighter/src/java/org/apache/lucene/search/uh

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1123: LUCENE-9093: Unified highlighter with word separator never gives context to the left

dsmiley commented on a change in pull request #1123: LUCENE-9093: Unified highlighter with word separator never gives context to the left URL: https://github.com/apache/lucene-solr/pull/1123#discussion_r361535945 ## File path: lucene/highlighter/src/test/org/apache/lucene/search/uh

[GitHub] [lucene-solr] Traktormaster commented on a change in pull request #1123: LUCENE-9093: Unified highlighter with word separator never gives context to the left

Traktormaster commented on a change in pull request #1123: LUCENE-9093: Unified highlighter with word separator never gives context to the left URL: https://github.com/apache/lucene-solr/pull/1123#discussion_r361533868 ## File path: lucene/highlighter/src/java/org/apache/lucene/sea

[GitHub] [lucene-solr] Traktormaster commented on a change in pull request #1123: LUCENE-9093: Unified highlighter with word separator never gives context to the left

Traktormaster commented on a change in pull request #1123: LUCENE-9093: Unified highlighter with word separator never gives context to the left URL: https://github.com/apache/lucene-solr/pull/1123#discussion_r361530659 ## File path: lucene/highlighter/src/java/org/apache/lucene/sea

[GitHub] [lucene-solr] Traktormaster commented on a change in pull request #1123: LUCENE-9093: Unified highlighter with word separator never gives context to the left

Traktormaster commented on a change in pull request #1123: LUCENE-9093: Unified highlighter with word separator never gives context to the left URL: https://github.com/apache/lucene-solr/pull/1123#discussion_r361529545 ## File path: lucene/highlighter/src/java/org/apache/lucene/sea

[jira] [Commented] (SOLR-13101) Shared storage support in SolrCloud

[ https://issues.apache.org/jira/browse/SOLR-13101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17003748#comment-17003748 ] ASF subversion and git services commented on SOLR-13101: Commit e

[GitHub] [lucene-solr] yonik merged pull request #1117: SOLR-13101: ant precommit fixes

yonik merged pull request #1117: SOLR-13101: ant precommit fixes URL: https://github.com/apache/lucene-solr/pull/1117 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [lucene-solr] yonik merged pull request #1115: SOLR-13101: Fix the gson version reference

yonik merged pull request #1115: SOLR-13101: Fix the gson version reference URL: https://github.com/apache/lucene-solr/pull/1115 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [lucene-solr] andyvuong commented on a change in pull request #1117: SOLR-13101: ant precommit fixes

andyvuong commented on a change in pull request #1117: SOLR-13101: ant precommit fixes URL: https://github.com/apache/lucene-solr/pull/1117#discussion_r361501107 ## File path: solr/core/src/java/org/apache/solr/store/blob/client/LocalStorageClient.java ## @@ -97,7 +117,7

[jira] [Commented] (SOLR-14141) eliminate JKS keystore from solr SSL docs

[ https://issues.apache.org/jira/browse/SOLR-14141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17003705#comment-17003705 ] Robert Muir commented on SOLR-14141: I added explicit {{-storetype PKCS12}}, for java

[jira] [Updated] (SOLR-14141) eliminate JKS keystore from solr SSL docs

[ https://issues.apache.org/jira/browse/SOLR-14141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated SOLR-14141: --- Attachment: SOLR-14141.patch > eliminate JKS keystore from solr SSL docs > --

[GitHub] [lucene-solr] Traktormaster commented on a change in pull request #1123: LUCENE-9093: Unified highlighter with word separator never gives context to the left

Traktormaster commented on a change in pull request #1123: LUCENE-9093: Unified highlighter with word separator never gives context to the left URL: https://github.com/apache/lucene-solr/pull/1123#discussion_r361492729 ## File path: lucene/highlighter/src/test/org/apache/lucene/sea

[GitHub] [lucene-solr] Traktormaster commented on a change in pull request #1123: LUCENE-9093: Unified highlighter with word separator never gives context to the left

Traktormaster commented on a change in pull request #1123: LUCENE-9093: Unified highlighter with word separator never gives context to the left URL: https://github.com/apache/lucene-solr/pull/1123#discussion_r361491499 ## File path: lucene/highlighter/src/java/org/apache/lucene/sea

[GitHub] [lucene-solr] dsmiley commented on issue #1109: More pervasive use of PackageLoader / PluginInfo

dsmiley commented on issue #1109: More pervasive use of PackageLoader / PluginInfo URL: https://github.com/apache/lucene-solr/pull/1109#issuecomment-569088078 I like the 3 categories of plugins very much, and also especially glad and surprised to hear you state "Hot reloading is not import

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1109: More pervasive use of PackageLoader / PluginInfo

dsmiley commented on a change in pull request #1109: More pervasive use of PackageLoader / PluginInfo URL: https://github.com/apache/lucene-solr/pull/1109#discussion_r361490021 ## File path: solr/core/src/java/org/apache/solr/schema/IndexSchemaFactory.java ## @@ -62,7 +62,

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1123: LUCENE-9093: Unified highlighter with word separator never gives context to the left

dsmiley commented on a change in pull request #1123: LUCENE-9093: Unified highlighter with word separator never gives context to the left URL: https://github.com/apache/lucene-solr/pull/1123#discussion_r361476978 ## File path: lucene/highlighter/src/java/org/apache/lucene/search/uh

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1123: LUCENE-9093: Unified highlighter with word separator never gives context to the left

dsmiley commented on a change in pull request #1123: LUCENE-9093: Unified highlighter with word separator never gives context to the left URL: https://github.com/apache/lucene-solr/pull/1123#discussion_r361471705 ## File path: lucene/highlighter/src/java/org/apache/lucene/search/uh

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1123: LUCENE-9093: Unified highlighter with word separator never gives context to the left

dsmiley commented on a change in pull request #1123: LUCENE-9093: Unified highlighter with word separator never gives context to the left URL: https://github.com/apache/lucene-solr/pull/1123#discussion_r361471554 ## File path: lucene/highlighter/src/java/org/apache/lucene/search/uh

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1123: LUCENE-9093: Unified highlighter with word separator never gives context to the left

dsmiley commented on a change in pull request #1123: LUCENE-9093: Unified highlighter with word separator never gives context to the left URL: https://github.com/apache/lucene-solr/pull/1123#discussion_r361472276 ## File path: lucene/highlighter/src/test/org/apache/lucene/search/uh

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1123: LUCENE-9093: Unified highlighter with word separator never gives context to the left

dsmiley commented on a change in pull request #1123: LUCENE-9093: Unified highlighter with word separator never gives context to the left URL: https://github.com/apache/lucene-solr/pull/1123#discussion_r361480777 ## File path: lucene/highlighter/src/java/org/apache/lucene/search/uh

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1123: LUCENE-9093: Unified highlighter with word separator never gives context to the left

dsmiley commented on a change in pull request #1123: LUCENE-9093: Unified highlighter with word separator never gives context to the left URL: https://github.com/apache/lucene-solr/pull/1123#discussion_r361472624 ## File path: lucene/highlighter/src/java/org/apache/lucene/search/uh

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1123: LUCENE-9093: Unified highlighter with word separator never gives context to the left

dsmiley commented on a change in pull request #1123: LUCENE-9093: Unified highlighter with word separator never gives context to the left URL: https://github.com/apache/lucene-solr/pull/1123#discussion_r361472335 ## File path: lucene/highlighter/src/test/org/apache/lucene/search/uh

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1123: LUCENE-9093: Unified highlighter with word separator never gives context to the left

dsmiley commented on a change in pull request #1123: LUCENE-9093: Unified highlighter with word separator never gives context to the left URL: https://github.com/apache/lucene-solr/pull/1123#discussion_r361482118 ## File path: lucene/highlighter/src/java/org/apache/lucene/search/uh

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1123: LUCENE-9093: Unified highlighter with word separator never gives context to the left

dsmiley commented on a change in pull request #1123: LUCENE-9093: Unified highlighter with word separator never gives context to the left URL: https://github.com/apache/lucene-solr/pull/1123#discussion_r361486777 ## File path: lucene/highlighter/src/java/org/apache/lucene/search/uh

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1123: LUCENE-9093: Unified highlighter with word separator never gives context to the left

dsmiley commented on a change in pull request #1123: LUCENE-9093: Unified highlighter with word separator never gives context to the left URL: https://github.com/apache/lucene-solr/pull/1123#discussion_r361483326 ## File path: lucene/highlighter/src/java/org/apache/lucene/search/uh

[GitHub] [lucene-solr] Traktormaster commented on a change in pull request #1123: LUCENE-9093: Unified highlighter with word separator never gives context to the left

Traktormaster commented on a change in pull request #1123: LUCENE-9093: Unified highlighter with word separator never gives context to the left URL: https://github.com/apache/lucene-solr/pull/1123#discussion_r361480642 ## File path: lucene/highlighter/src/java/org/apache/lucene/sea

[jira] [Commented] (SOLR-14151) Make schema components load from packages

[ https://issues.apache.org/jira/browse/SOLR-14151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17003668#comment-17003668 ] Jan Høydahl commented on SOLR-14151: i was thinking about refGuide updates, might be

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1123: LUCENE-9093: Unified highlighter with word separator never gives context to the left

dsmiley commented on a change in pull request #1123: LUCENE-9093: Unified highlighter with word separator never gives context to the left URL: https://github.com/apache/lucene-solr/pull/1123#discussion_r361471274 ## File path: lucene/highlighter/src/java/org/apache/lucene/search/uh

[jira] [Commented] (LUCENE-4702) Terms dictionary compression

[ https://issues.apache.org/jira/browse/LUCENE-4702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17003640#comment-17003640 ] Adrien Grand commented on LUCENE-4702: -- I finally explored a different path: JDK13

[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1124: SOLR-14151 :Schema components to be loadable from packages

noblepaul commented on a change in pull request #1124: SOLR-14151 :Schema components to be loadable from packages URL: https://github.com/apache/lucene-solr/pull/1124#discussion_r361455949 ## File path: solr/core/src/java/org/apache/solr/core/PluginInfo.java ## @@ -63,29 +

[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1124: SOLR-14151 :Schema components to be loadable from packages

noblepaul commented on a change in pull request #1124: SOLR-14151 :Schema components to be loadable from packages URL: https://github.com/apache/lucene-solr/pull/1124#discussion_r361456012 ## File path: solr/core/src/java/org/apache/solr/schema/IndexSchema.java ## @@ -1981

[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1124: SOLR-14151 :Schema components to be loadable from packages

noblepaul commented on a change in pull request #1124: SOLR-14151 :Schema components to be loadable from packages URL: https://github.com/apache/lucene-solr/pull/1124#discussion_r361456012 ## File path: solr/core/src/java/org/apache/solr/schema/IndexSchema.java ## @@ -1981

[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1124: SOLR-14151 :Schema components to be loadable from packages

noblepaul commented on a change in pull request #1124: SOLR-14151 :Schema components to be loadable from packages URL: https://github.com/apache/lucene-solr/pull/1124#discussion_r361455888 ## File path: solr/core/src/java/org/apache/solr/core/SolrCore.java ## @@ -935,6 +94

[GitHub] [lucene-solr] jpountz opened a new pull request #1126: LUCENE-5201: Terms dictionary compression.

jpountz opened a new pull request #1126: LUCENE-5201: Terms dictionary compression. URL: https://github.com/apache/lucene-solr/pull/1126 Compress blocks of suffixes in order to make the terms dictionary more space-efficient. Two compression algorithms are used depending on which one is

[GitHub] [lucene-solr] Traktormaster commented on a change in pull request #1123: LUCENE-9093: Unified highlighter with word separator never gives context to the left

Traktormaster commented on a change in pull request #1123: LUCENE-9093: Unified highlighter with word separator never gives context to the left URL: https://github.com/apache/lucene-solr/pull/1123#discussion_r361432710 ## File path: lucene/highlighter/src/java/org/apache/lucene/sea

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1049: LUCENE-9074: Slice Allocation Circuit Breakers in IndexSearcher

jpountz commented on a change in pull request #1049: LUCENE-9074: Slice Allocation Circuit Breakers in IndexSearcher URL: https://github.com/apache/lucene-solr/pull/1049#discussion_r361429190 ## File path: lucene/core/src/java/org/apache/lucene/search/SliceExecutionControlPlane.jav

[GitHub] [lucene-solr] Traktormaster commented on a change in pull request #1123: LUCENE-9093: Unified highlighter with word separator never gives context to the left

Traktormaster commented on a change in pull request #1123: LUCENE-9093: Unified highlighter with word separator never gives context to the left URL: https://github.com/apache/lucene-solr/pull/1123#discussion_r361426082 ## File path: lucene/highlighter/src/java/org/apache/lucene/sea

[jira] [Commented] (SOLR-14102) FacetModule use number of responses from shards as number of shards

[ https://issues.apache.org/jira/browse/SOLR-14102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17003562#comment-17003562 ] Mikhail Khludnev commented on SOLR-14102: - I think we need to assert it somehow v

[jira] [Commented] (SOLR-14151) Make schema components load from packages

[ https://issues.apache.org/jira/browse/SOLR-14151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17003552#comment-17003552 ] Noble Paul commented on SOLR-14151: --- I can't comment on SPI now. All I can say is that

[jira] [Commented] (SOLR-14151) Make schema components load from packages

[ https://issues.apache.org/jira/browse/SOLR-14151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17003545#comment-17003545 ] Jan Høydahl commented on SOLR-14151: Please clarify how this relates to the style of

[jira] [Commented] (SOLR-14102) FacetModule use number of responses from shards as number of shards

[ https://issues.apache.org/jira/browse/SOLR-14102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17003543#comment-17003543 ] Lucene/Solr QA commented on SOLR-14102: --- | (x) *{color:red}-1 overall{color}* | \\

[GitHub] [lucene-solr] janhoy commented on a change in pull request #1124: SOLR-14151 :Schema components to be loadable from packages

janhoy commented on a change in pull request #1124: SOLR-14151 :Schema components to be loadable from packages URL: https://github.com/apache/lucene-solr/pull/1124#discussion_r361408293 ## File path: solr/core/src/java/org/apache/solr/core/SolrCore.java ## @@ -935,6 +945,7

[GitHub] [lucene-solr] janhoy commented on a change in pull request #1124: SOLR-14151 :Schema components to be loadable from packages

janhoy commented on a change in pull request #1124: SOLR-14151 :Schema components to be loadable from packages URL: https://github.com/apache/lucene-solr/pull/1124#discussion_r361408428 ## File path: solr/core/src/java/org/apache/solr/core/PluginInfo.java ## @@ -63,29 +63,

[GitHub] [lucene-solr] janhoy commented on a change in pull request #1124: SOLR-14151 :Schema components to be loadable from packages

janhoy commented on a change in pull request #1124: SOLR-14151 :Schema components to be loadable from packages URL: https://github.com/apache/lucene-solr/pull/1124#discussion_r361411570 ## File path: solr/core/src/java/org/apache/solr/schema/IndexSchema.java ## @@ -1981,4

[GitHub] [lucene-solr] noblepaul commented on issue #1109: More pervasive use of PackageLoader / PluginInfo

noblepaul commented on issue #1109: More pervasive use of PackageLoader / PluginInfo URL: https://github.com/apache/lucene-solr/pull/1109#issuecomment-569014248 > RE "inconsistent state": Put differently, I think you are just pointing out that this PR is not loading the correct version? Ye

[GitHub] [lucene-solr] noblepaul removed a comment on issue #1109: More pervasive use of PackageLoader / PluginInfo

noblepaul removed a comment on issue #1109: More pervasive use of PackageLoader / PluginInfo URL: https://github.com/apache/lucene-solr/pull/1109#issuecomment-568981311 @dsmiley The comments are not supposed to be personal. These are my observations on the code/PR. I'm sure somebody is goi

[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1109: More pervasive use of PackageLoader / PluginInfo

noblepaul commented on a change in pull request #1109: More pervasive use of PackageLoader / PluginInfo URL: https://github.com/apache/lucene-solr/pull/1109#discussion_r361401294 ## File path: solr/core/src/java/org/apache/solr/core/DirectoryFactory.java ## @@ -420,7 +420,

[GitHub] [lucene-solr] mkhludnev commented on a change in pull request #1122: SOLR-12490 Added parsing of json.queries for referring in JSON facets

mkhludnev commented on a change in pull request #1122: SOLR-12490 Added parsing of json.queries for referring in JSON facets URL: https://github.com/apache/lucene-solr/pull/1122#discussion_r361400807 ## File path: solr/core/src/java/org/apache/solr/request/json/JsonQueryConverter.j

[GitHub] [lucene-solr] mkhludnev commented on a change in pull request #1122: SOLR-12490 Added parsing of json.queries for referring in JSON facets

mkhludnev commented on a change in pull request #1122: SOLR-12490 Added parsing of json.queries for referring in JSON facets URL: https://github.com/apache/lucene-solr/pull/1122#discussion_r361401011 ## File path: solr/core/src/java/org/apache/solr/request/json/RequestUtil.java ###

[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1109: More pervasive use of PackageLoader / PluginInfo

noblepaul commented on a change in pull request #1109: More pervasive use of PackageLoader / PluginInfo URL: https://github.com/apache/lucene-solr/pull/1109#discussion_r361375529 ## File path: solr/core/src/java/org/apache/solr/schema/IndexSchemaFactory.java ## @@ -62,7 +6

[GitHub] [lucene-solr] a-siuniaev commented on a change in pull request #1122: SOLR-12490 Added parsing of json.queries for referring in JSON facets

a-siuniaev commented on a change in pull request #1122: SOLR-12490 Added parsing of json.queries for referring in JSON facets URL: https://github.com/apache/lucene-solr/pull/1122#discussion_r361398204 ## File path: solr/core/src/java/org/apache/solr/request/json/RequestUtil.java ##

[GitHub] [lucene-solr] a-siuniaev commented on a change in pull request #1122: SOLR-12490 Added parsing of json.queries for referring in JSON facets

a-siuniaev commented on a change in pull request #1122: SOLR-12490 Added parsing of json.queries for referring in JSON facets URL: https://github.com/apache/lucene-solr/pull/1122#discussion_r361398218 ## File path: solr/core/src/java/org/apache/solr/request/json/RequestUtil.java ##

[GitHub] [lucene-solr] a-siuniaev commented on a change in pull request #1122: SOLR-12490 Added parsing of json.queries for referring in JSON facets

a-siuniaev commented on a change in pull request #1122: SOLR-12490 Added parsing of json.queries for referring in JSON facets URL: https://github.com/apache/lucene-solr/pull/1122#discussion_r361397810 ## File path: solr/core/src/java/org/apache/solr/request/json/RequestUtil.java ##