dsmiley commented on a change in pull request #1124: SOLR-14151 :Schema
components to be loadable from packages
URL: https://github.com/apache/lucene-solr/pull/1124#discussion_r361543861
##########
File path: solr/core/src/java/org/apache/solr/core/ConfigSet.java
##########
@@ -51,8 +53,11 @@ public SolrConfig getSolrConfig() {
return solrconfig;
}
+ public Supplier<IndexSchema> getIndexSchemaSupplier() {
Review comment:
Based on what I'm seeing in this PR, it appears this Supplier will in fact
load the schema each time get() is called? If so that sounds easy to
accidentally over-load the schema. Might a `Future` work better?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
