noblepaul commented on a change in pull request #1124: SOLR-14151 :Schema
components to be loadable from packages
URL: https://github.com/apache/lucene-solr/pull/1124#discussion_r361455949
##########
File path: solr/core/src/java/org/apache/solr/core/PluginInfo.java
##########
@@ -63,29 +63,42 @@ public PluginInfo(String type, Map<String, String> attrs,
NamedList initArgs, Li
/** class names can be prefixed with package name e.g:
my_package:my.pkg.Class
* This checks if it is a package name prefixed classname.
- * the return value has first = package name & second = class name
*/
- static Pair<String,String > parseClassName(String name) {
- String pkgName = null;
- String className = name;
- if (name != null) {
- int colonIdx = name.indexOf(':');
- if (colonIdx > -1) {
- pkgName = name.substring(0, colonIdx);
- className = name.substring(colonIdx + 1);
+
+ public static class ClassName {
Review comment:
I didn't like the name either. Suggestions welcome
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
