dsmiley commented on a change in pull request #1124: SOLR-14151 :Schema
components to be loadable from packages
URL: https://github.com/apache/lucene-solr/pull/1124#discussion_r361578750
##########
File path: solr/core/src/java/org/apache/solr/handler/SchemaHandler.java
##########
@@ -200,6 +206,38 @@ private void handleGET(SolrQueryRequest req,
SolrQueryResponse rsp) {
}
}
+ private void insertPackageInfo(Object o, SolrQueryRequest req) {
Review comment:
Could use a javadoc line saying what is put where. Also if it took
SolrQueryResponse and not 'o', I think it would be clearer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
