dsmiley commented on a change in pull request #1123: LUCENE-9093: Unified
highlighter with word separator never gives context to the left
URL: https://github.com/apache/lucene-solr/pull/1123#discussion_r361471705
##########
File path:
lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/LengthGoalBreakIterator.java
##########
@@ -44,17 +44,30 @@ public static LengthGoalBreakIterator
createMinLength(BreakIterator baseIter, in
return new LengthGoalBreakIterator(baseIter, minLength,
fragmentAlignment,true);
}
+ /** For backwards compatibility you can initialise the break iterator
without fragmentAlignment. */
+ public static LengthGoalBreakIterator createMinLength(BreakIterator
baseIter, int minLength) {
+ return createMinLength(baseIter, minLength, 0.f);
+ }
+
/** Breaks will be on average {@code targetLength} apart; the closest break
to this target (before or after)
* is chosen. */
public static LengthGoalBreakIterator createClosestToLength(BreakIterator
baseIter, int targetLength,
Review comment:
Please document fragmentAlignment
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
