singhpk234 commented on code in PR #6655:
URL: https://github.com/apache/iceberg/pull/6655#discussion_r1094215115
##
core/src/main/java/org/apache/iceberg/hadoop/Util.java:
##
@@ -84,10 +84,16 @@ public static String[] blockLocations(FileIO io,
ScanTaskGroup taskGroup) {
r
rbalamohan opened a new issue, #6726:
URL: https://github.com/apache/iceberg/issues/6726
### Apache Iceberg version
1.0.0
### Query engine
Hive
### Please describe the bug 🐞
Context:
==
Split computation in iceberg takes 3-5 seconds (in certain qu
boroknagyz commented on issue #6709:
URL: https://github.com/apache/iceberg/issues/6709#issuecomment-1413400733
I think we cannot assume that numRows(table) is equal to numRows(data files)
- numRows(position delete files).
Because
- Concurent deletes might create delete files t
jedrek-VL commented on issue #6713:
URL: https://github.com/apache/iceberg/issues/6713#issuecomment-1413425607
Ok, I managed to make it work by replacing the `load_catalog` code by the
following:
```
catalog = load_catalog('default', **{
'uri': 'http://localhost:8181',
jedrek-VL closed issue #6713: PyIceberg fails when querying REST catalog
URL: https://github.com/apache/iceberg/issues/6713
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
pvary commented on code in PR #6648:
URL: https://github.com/apache/iceberg/pull/6648#discussion_r1094266424
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveLock.java:
##
@@ -0,0 +1,27 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
pvary commented on code in PR #6648:
URL: https://github.com/apache/iceberg/pull/6648#discussion_r1094267066
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java:
##
@@ -135,13 +92,6 @@ public class HiveTableOperations extends
BaseMetastoreTableOpera
pvary commented on code in PR #6648:
URL: https://github.com/apache/iceberg/pull/6648#discussion_r1094267540
##
hive-metastore/src/main/java/org/apache/iceberg/hive/MetastoreLock.java:
##
@@ -0,0 +1,538 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
pvary commented on code in PR #6648:
URL: https://github.com/apache/iceberg/pull/6648#discussion_r1094267902
##
hive-metastore/src/main/java/org/apache/iceberg/hive/MetastoreLock.java:
##
@@ -0,0 +1,538 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
pvary commented on code in PR #6648:
URL: https://github.com/apache/iceberg/pull/6648#discussion_r1094268240
##
hive-metastore/src/main/java/org/apache/iceberg/hive/MetastoreLock.java:
##
@@ -0,0 +1,538 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
pvary commented on code in PR #6648:
URL: https://github.com/apache/iceberg/pull/6648#discussion_r1094268929
##
hive-metastore/src/main/java/org/apache/iceberg/hive/MetastoreLock.java:
##
@@ -0,0 +1,538 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
ajantha-bhat commented on PR #6712:
URL: https://github.com/apache/iceberg/pull/6712#issuecomment-1413808807
Thanks @dimas-b for the review.
@snazy : Do you have any suggestions for this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please
Fokko commented on issue #6713:
URL: https://github.com/apache/iceberg/issues/6713#issuecomment-1413913229
Thanks @jedrek-VL for the comprehensive write-up. I'm just seeing this now.
Yesterday the docker image was updated with a PyIceberg notebook, I would
recommend pulling the latest conta
deniskuzZ commented on PR #6653:
URL: https://github.com/apache/iceberg/pull/6653#issuecomment-1413922192
hi @pvary, could you please help?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
nastra commented on code in PR #6723:
URL: https://github.com/apache/iceberg/pull/6723#discussion_r1094663480
##
docs/branching-and-tagging.md:
##
@@ -0,0 +1,218 @@
+---
+title: "Branching and Tagging"
+url: configuration
+aliases:
+- "tables/branching"
+menu:
+main:
+
Fokko commented on code in PR #6482:
URL: https://github.com/apache/iceberg/pull/6482#discussion_r1094693759
##
api/src/main/java/org/apache/iceberg/PartitionSpec.java:
##
@@ -440,7 +440,7 @@ public Builder year(String sourceName, String targetName) {
sourceColumn
nastra commented on code in PR #6712:
URL: https://github.com/apache/iceberg/pull/6712#discussion_r1094703306
##
nessie/src/main/java/org/apache/iceberg/nessie/NessieCatalog.java:
##
@@ -88,11 +89,22 @@ public void initialize(String name, Map
options) {
options.get(rem
deniskuzZ commented on PR #6653:
URL: https://github.com/apache/iceberg/pull/6653#issuecomment-1413952926
> Sorry for the late reply, I was traveling the last few days. I like this
solution. It is until Iceberg 2.0.0 that we have to keep the lazy and non-lazy
versions of initializing a Part
ajantha-bhat commented on code in PR #6712:
URL: https://github.com/apache/iceberg/pull/6712#discussion_r1094732867
##
nessie/src/test/java/org/apache/iceberg/nessie/TestNamespace.java:
##
@@ -73,6 +77,48 @@ public void testListNamespaces() {
Assertions.assertThat(namespace
ajantha-bhat commented on code in PR #6712:
URL: https://github.com/apache/iceberg/pull/6712#discussion_r1094732867
##
nessie/src/test/java/org/apache/iceberg/nessie/TestNamespace.java:
##
@@ -73,6 +77,48 @@ public void testListNamespaces() {
Assertions.assertThat(namespace
nastra commented on PR #6674:
URL: https://github.com/apache/iceberg/pull/6674#issuecomment-1413975497
would be good to also get feedback from @danielcweeks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
zhangbutao commented on PR #6482:
URL: https://github.com/apache/iceberg/pull/6482#issuecomment-1413976249
> Sorry for being late to the party here, I was traveling the last few days.
I would be in favor of #6653 if that also solves your problem.
Never mind :). Yes, https://github.com
nastra commented on code in PR #6712:
URL: https://github.com/apache/iceberg/pull/6712#discussion_r1094773774
##
nessie/src/main/java/org/apache/iceberg/nessie/NessieCatalog.java:
##
@@ -103,7 +103,9 @@ public void initialize(String name, Map
options) {
api = nessieClien
rdblue commented on code in PR #6622:
URL: https://github.com/apache/iceberg/pull/6622#discussion_r1094775999
##
api/src/main/java/org/apache/iceberg/expressions/BoundAggregate.java:
##
@@ -44,4 +57,85 @@ public Type type() {
return term().type();
}
}
+
+ public
nastra commented on code in PR #6712:
URL: https://github.com/apache/iceberg/pull/6712#discussion_r1094775416
##
nessie/src/main/java/org/apache/iceberg/nessie/NessieCatalog.java:
##
@@ -103,7 +103,9 @@ public void initialize(String name, Map
options) {
api = nessieClien
rdblue commented on code in PR #6622:
URL: https://github.com/apache/iceberg/pull/6622#discussion_r1094779610
##
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/SparkReadOptions.java:
##
@@ -90,4 +90,6 @@ private SparkReadOptions() {}
public static final String VERSIO
rdblue commented on code in PR #6622:
URL: https://github.com/apache/iceberg/pull/6622#discussion_r1094780732
##
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/SparkSQLProperties.java:
##
@@ -47,4 +47,8 @@ private SparkSQLProperties() {}
public static final String PR
rdblue commented on code in PR #6622:
URL: https://github.com/apache/iceberg/pull/6622#discussion_r1094789846
##
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/SparkLocalScan.java:
##
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
Fokko commented on issue #6620:
URL: https://github.com/apache/iceberg/issues/6620#issuecomment-1414042971
Thanks for pining for me @srilman
Most libraries can vary the version, and some are fixed. For example,
`aiobotocore` is linked to `boto3`. For Arrow, I think you're okay using
Fokko commented on PR #6482:
URL: https://github.com/apache/iceberg/pull/6482#issuecomment-1414044966
Thanks for letting me know and creating the PR in the first place, much
appreciated 👍🏻
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
Fokko closed pull request #6482: API: Fix inconsistent TimeTransform Type
URL: https://github.com/apache/iceberg/pull/6482
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
Fokko merged PR #6653:
URL: https://github.com/apache/iceberg/pull/6653
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apach
rdblue commented on code in PR #6622:
URL: https://github.com/apache/iceberg/pull/6622#discussion_r1094796934
##
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/SparkScanBuilder.java:
##
@@ -158,6 +182,141 @@ public Filter[] pushedFilters() {
return pushedFil
rdblue commented on code in PR #6622:
URL: https://github.com/apache/iceberg/pull/6622#discussion_r1094798295
##
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/SparkScanBuilder.java:
##
@@ -158,6 +182,141 @@ public Filter[] pushedFilters() {
return pushedFil
rdblue commented on code in PR #6622:
URL: https://github.com/apache/iceberg/pull/6622#discussion_r1094799318
##
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/SparkScanBuilder.java:
##
@@ -158,6 +182,141 @@ public Filter[] pushedFilters() {
return pushedFil
jedrek-VL commented on issue #6713:
URL: https://github.com/apache/iceberg/issues/6713#issuecomment-1414051660
Right. I saw the new docker images and that's how I found out what I was
missing :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please
rdblue commented on code in PR #6622:
URL: https://github.com/apache/iceberg/pull/6622#discussion_r1094803125
##
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/SparkScanBuilder.java:
##
@@ -158,6 +182,141 @@ public Filter[] pushedFilters() {
return pushedFil
RussellSpitzer commented on issue #6725:
URL: https://github.com/apache/iceberg/issues/6725#issuecomment-1414053888
There is no such thing in iceberg. If there is data in a partition the
commit has suceeded. So if for example you do a Spark Query and there is data
in the partition, that mea
rdblue commented on code in PR #6622:
URL: https://github.com/apache/iceberg/pull/6622#discussion_r1094803125
##
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/SparkScanBuilder.java:
##
@@ -158,6 +182,141 @@ public Filter[] pushedFilters() {
return pushedFil
rdblue commented on code in PR #6622:
URL: https://github.com/apache/iceberg/pull/6622#discussion_r1094814986
##
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/SparkScanBuilder.java:
##
@@ -158,6 +182,141 @@ public Filter[] pushedFilters() {
return pushedFil
rdblue commented on code in PR #6622:
URL: https://github.com/apache/iceberg/pull/6622#discussion_r1094817232
##
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/SparkScanBuilder.java:
##
@@ -158,6 +182,141 @@ public Filter[] pushedFilters() {
return pushedFil
dimas-b commented on code in PR #6712:
URL: https://github.com/apache/iceberg/pull/6712#discussion_r1094829567
##
nessie/src/test/java/org/apache/iceberg/nessie/TestNamespace.java:
##
@@ -73,6 +77,48 @@ public void testListNamespaces() {
Assertions.assertThat(namespaces).is
szehon-ho commented on code in PR #6716:
URL: https://github.com/apache/iceberg/pull/6716#discussion_r1093922634
##
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/PositionDeleteRowReader.java:
##
@@ -0,0 +1,114 @@
+/*
+ * Licensed to the Apache Software Foundatio
szehon-ho commented on code in PR #6716:
URL: https://github.com/apache/iceberg/pull/6716#discussion_r1094106234
##
parquet/src/main/java/org/apache/iceberg/parquet/ParquetMetricsRowGroupFilter.java:
##
@@ -50,15 +51,22 @@ public class ParquetMetricsRowGroupFilter {
private
rdblue merged PR #6720:
URL: https://github.com/apache/iceberg/pull/6720
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac
rdblue commented on PR #6720:
URL: https://github.com/apache/iceberg/pull/6720#issuecomment-1414172576
Sounds reasonable to me. We could also version the docs eventually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
snazy opened a new issue, #6727:
URL: https://github.com/apache/iceberg/issues/6727
### Apache Iceberg version
None
### Query engine
None
### Please describe the bug 🐞
The current REST client / OpenAPI spec defines the attribute `stageCreate`.
The RES
snazy commented on PR #6701:
URL: https://github.com/apache/iceberg/pull/6701#issuecomment-1414201166
(Side note: I no longer use the the rest-spec in my experiments - for
various reasons - and use the JSON serialization from `iceberg-core`.)
But IMO the spec should exactly reflect th
snazy commented on PR #6700:
URL: https://github.com/apache/iceberg/pull/6700#issuecomment-1414203692
I needed this, while I was trying (without success for many reasons) to
generate JAX-RS code from the spec. Such an approach would need this change.
I'm okay to leave it as it is. Mos
aokolnychyi commented on code in PR #6716:
URL: https://github.com/apache/iceberg/pull/6716#discussion_r1094892920
##
core/src/main/java/org/apache/iceberg/PositionDeletesTable.java:
##
@@ -75,16 +75,15 @@ public Schema schema() {
return schema;
}
- private Schema cal
snazy commented on issue #6727:
URL: https://github.com/apache/iceberg/issues/6727#issuecomment-1414242918
(Sorry, my bad, seems that _both_ can happen.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
snazy closed issue #6727: REST-Catalog: CreateTableRequest.stageCreate can be
removed
URL: https://github.com/apache/iceberg/issues/6727
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
aokolnychyi commented on code in PR #6716:
URL: https://github.com/apache/iceberg/pull/6716#discussion_r1094981997
##
core/src/main/java/org/apache/iceberg/MetadataTable.java:
##
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more cont
RussellSpitzer commented on code in PR #6682:
URL: https://github.com/apache/iceberg/pull/6682#discussion_r1095005897
##
api/src/main/java/org/apache/iceberg/actions/DeleteOrphanFiles.java:
##
@@ -67,7 +67,11 @@ public interface DeleteOrphanFiles extends
Action
RussellSpitzer commented on code in PR #6682:
URL: https://github.com/apache/iceberg/pull/6682#discussion_r1095006673
##
api/src/main/java/org/apache/iceberg/actions/DeleteOrphanFiles.java:
##
@@ -80,9 +84,16 @@ public interface DeleteOrphanFiles extends
Action>
deleteFunc) {
flyrain commented on code in PR #6638:
URL: https://github.com/apache/iceberg/pull/6638#discussion_r1095008197
##
spark/v3.3/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestReplaceBranch.java:
##
@@ -0,0 +1,273 @@
+/*
+ * Licensed to the Apache Software Fo
RussellSpitzer commented on code in PR #6682:
URL: https://github.com/apache/iceberg/pull/6682#discussion_r1095009182
##
api/src/main/java/org/apache/iceberg/actions/DeleteOrphanFiles.java:
##
@@ -80,9 +84,16 @@ public interface DeleteOrphanFiles extends
Action
RussellSpitzer commented on code in PR #6682:
URL: https://github.com/apache/iceberg/pull/6682#discussion_r1095010538
##
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/actions/BaseSparkAction.java:
##
@@ -85,6 +88,7 @@
private static final Logger LOG =
LoggerFactory
RussellSpitzer commented on code in PR #6682:
URL: https://github.com/apache/iceberg/pull/6682#discussion_r1095010538
##
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/actions/BaseSparkAction.java:
##
@@ -85,6 +88,7 @@
private static final Logger LOG =
LoggerFactory
RussellSpitzer commented on code in PR #6682:
URL: https://github.com/apache/iceberg/pull/6682#discussion_r1095013112
##
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/actions/BaseSparkAction.java:
##
@@ -253,6 +257,39 @@ protected DeleteSummary deleteFiles(
return
flyrain commented on code in PR #6638:
URL: https://github.com/apache/iceberg/pull/6638#discussion_r1095013576
##
spark/v3.3/spark-extensions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/CreateOrReplaceBranchExec.scala:
##
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the
huaxingao commented on code in PR #6622:
URL: https://github.com/apache/iceberg/pull/6622#discussion_r1095044926
##
api/src/main/java/org/apache/iceberg/expressions/BoundAggregate.java:
##
@@ -44,4 +57,85 @@ public Type type() {
return term().type();
}
}
+
+ publ
szehon-ho commented on code in PR #6716:
URL: https://github.com/apache/iceberg/pull/6716#discussion_r1094108930
##
orc/src/main/java/org/apache/iceberg/orc/OrcIterable.java:
##
@@ -84,15 +91,18 @@ public CloseableIterator iterator() {
addCloseable(orcFileReader);
Ty
amogh-jahagirdar commented on code in PR #6648:
URL: https://github.com/apache/iceberg/pull/6648#discussion_r1095119030
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveLock.java:
##
@@ -0,0 +1,27 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+
amogh-jahagirdar commented on code in PR #6648:
URL: https://github.com/apache/iceberg/pull/6648#discussion_r1095119030
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveLock.java:
##
@@ -0,0 +1,27 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+
amogh-jahagirdar commented on code in PR #6648:
URL: https://github.com/apache/iceberg/pull/6648#discussion_r1095120594
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveLock.java:
##
@@ -0,0 +1,27 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+
amogh-jahagirdar commented on code in PR #6648:
URL: https://github.com/apache/iceberg/pull/6648#discussion_r1095121483
##
hive-metastore/src/main/java/org/apache/iceberg/hive/MetastoreLock.java:
##
@@ -0,0 +1,540 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
amogh-jahagirdar commented on PR #6648:
URL: https://github.com/apache/iceberg/pull/6648#issuecomment-1414426100
Thanks for the detailed explanations @pvary I agree it does seem difficult
to reconcile the two abstractions at this point. The only thing on my side is
can we confirm if all the
amogh-jahagirdar commented on code in PR #6638:
URL: https://github.com/apache/iceberg/pull/6638#discussion_r1095128415
##
spark/v3.3/spark-extensions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/CreateOrReplaceBranchExec.scala:
##
@@ -0,0 +1,82 @@
+/*
+ * Licens
amogh-jahagirdar commented on code in PR #6638:
URL: https://github.com/apache/iceberg/pull/6638#discussion_r1095128415
##
spark/v3.3/spark-extensions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/CreateOrReplaceBranchExec.scala:
##
@@ -0,0 +1,82 @@
+/*
+ * Licens
amogh-jahagirdar commented on code in PR #6638:
URL: https://github.com/apache/iceberg/pull/6638#discussion_r1095128415
##
spark/v3.3/spark-extensions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/CreateOrReplaceBranchExec.scala:
##
@@ -0,0 +1,82 @@
+/*
+ * Licens
amogh-jahagirdar commented on code in PR #6638:
URL: https://github.com/apache/iceberg/pull/6638#discussion_r1095133181
##
spark/v3.3/spark-extensions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/CreateOrReplaceBranchExec.scala:
##
@@ -0,0 +1,82 @@
+/*
+ * Licens
amogh-jahagirdar commented on code in PR #6638:
URL: https://github.com/apache/iceberg/pull/6638#discussion_r1095134625
##
spark/v3.3/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestReplaceBranch.java:
##
@@ -0,0 +1,273 @@
+/*
+ * Licensed to the Apache So
amogh-jahagirdar commented on PR #6638:
URL: https://github.com/apache/iceberg/pull/6638#issuecomment-1414441586
Thanks for the review @flyrain really appreciate it!
So there are a few operations:
1.) replaceBranch (this PR) -> Replace branch will change the snapshot that
haydenflinner commented on issue #2040:
URL: https://github.com/apache/iceberg/issues/2040#issuecomment-1414446899
Same thing here, happening whether I use INSERT INTO or the dataframe API.
How annoying. Is there really no solution besides messing with the dataframe
schema to ensure it has
RussellSpitzer commented on issue #2040:
URL: https://github.com/apache/iceberg/issues/2040#issuecomment-1414466758
Both Spark and Iceberg have their own checks to determine whether an input
schema is valid for writing to a given table. The Spark checks are first and
require that all of the
amogh-jahagirdar commented on PR #6637:
URL: https://github.com/apache/iceberg/pull/6637#issuecomment-1414473094
@hililiwei similar to https://github.com/apache/iceberg/pull/6638 could this
PR encapsulate create/replace? We came to the conclusion on the replace PR it
made more sense to just
aokolnychyi commented on code in PR #6655:
URL: https://github.com/apache/iceberg/pull/6655#discussion_r1095169075
##
core/src/main/java/org/apache/iceberg/hadoop/Util.java:
##
@@ -84,10 +88,38 @@ public static String[] blockLocations(FileIO io,
ScanTaskGroup taskGroup) {
jackye1995 commented on PR #6638:
URL: https://github.com/apache/iceberg/pull/6638#issuecomment-1414492620
Looks like we have enough votes and all comments are addressed. I will go
ahead to merge this, and we can address further comments in subsequent PRs like
#6637
Thanks @amogh-ja
jackye1995 merged PR #6638:
URL: https://github.com/apache/iceberg/pull/6638
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.
amogh-jahagirdar commented on PR #6638:
URL: https://github.com/apache/iceberg/pull/6638#issuecomment-1414496739
Thanks for the reviews @flyrain @jackye1995 @yyanyy @hililiwei!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
github-actions[bot] closed issue #5163: Support catalog method to set table
metadata
URL: https://github.com/apache/iceberg/issues/5163
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
github-actions[bot] commented on issue #4607:
URL: https://github.com/apache/iceberg/issues/4607#issuecomment-1414537066
This issue has been closed because it has not received any activity in the
last 14 days since being marked as 'stale'
--
This is an automated message from the Apache Gi
github-actions[bot] commented on issue #5163:
URL: https://github.com/apache/iceberg/issues/5163#issuecomment-1414537028
This issue has been closed because it has not received any activity in the
last 14 days since being marked as 'stale'
--
This is an automated message from the Apache Gi
github-actions[bot] closed issue #4607: [Docs] Create an item list for
re-organizing docs to the proposed layout
URL: https://github.com/apache/iceberg/issues/4607
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
aokolnychyi commented on PR #6695:
URL: https://github.com/apache/iceberg/pull/6695#issuecomment-1414545406
My bad, I overlooked the condition, @ajantha-bhat!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
aokolnychyi merged PR #6695:
URL: https://github.com/apache/iceberg/pull/6695
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg
aokolnychyi commented on PR #6695:
URL: https://github.com/apache/iceberg/pull/6695#issuecomment-1414546166
Thanks, @ajantha-bhat! I merged this. Would you mind following up with
cherry-picks to other versions?
--
This is an automated message from the Apache Git Service.
To respond to the
aokolnychyi commented on PR #6700:
URL: https://github.com/apache/iceberg/pull/6700#issuecomment-1414548715
Sounds good, @snazy. Would you mind closing this one and re-opening if
needed? Trying to reduce the number of open PRs against our repo.
--
This is an automated message from the Apa
aokolnychyi commented on code in PR #6682:
URL: https://github.com/apache/iceberg/pull/6682#discussion_r1095231341
##
api/src/main/java/org/apache/iceberg/actions/DeleteOrphanFiles.java:
##
@@ -67,7 +67,11 @@ public interface DeleteOrphanFiles extends
Action For example, if I h
aokolnychyi commented on code in PR #6682:
URL: https://github.com/apache/iceberg/pull/6682#discussion_r1095234465
##
api/src/main/java/org/apache/iceberg/actions/DeleteOrphanFiles.java:
##
@@ -80,9 +84,16 @@ public interface DeleteOrphanFiles extends
Action>
deleteFunc) {
Re
aokolnychyi commented on code in PR #6682:
URL: https://github.com/apache/iceberg/pull/6682#discussion_r1095234465
##
api/src/main/java/org/apache/iceberg/actions/DeleteOrphanFiles.java:
##
@@ -80,9 +84,16 @@ public interface DeleteOrphanFiles extends
Action>
deleteFunc) {
Re
aokolnychyi commented on code in PR #6682:
URL: https://github.com/apache/iceberg/pull/6682#discussion_r1095236241
##
api/src/main/java/org/apache/iceberg/actions/DeleteOrphanFiles.java:
##
@@ -67,7 +67,11 @@ public interface DeleteOrphanFiles extends
Action
aokolnychyi commented on code in PR #6682:
URL: https://github.com/apache/iceberg/pull/6682#discussion_r1095234465
##
api/src/main/java/org/apache/iceberg/actions/DeleteOrphanFiles.java:
##
@@ -80,9 +84,16 @@ public interface DeleteOrphanFiles extends
Action>
deleteFunc) {
Re
jackye1995 commented on PR #6637:
URL: https://github.com/apache/iceberg/pull/6637#issuecomment-1414576132
> could this PR encapsulate create/replace?
+1
Let me know when this is updated, I will take another look!
--
This is an automated message from the Apache Git Service.
T
jackye1995 commented on code in PR #5029:
URL: https://github.com/apache/iceberg/pull/5029#discussion_r1095248368
##
flink/v1.16/flink/src/main/java/org/apache/iceberg/flink/source/FlinkSplitPlanner.java:
##
@@ -86,10 +86,18 @@ static CloseableIterable planTasks(
Incremen
jackye1995 commented on code in PR #5029:
URL: https://github.com/apache/iceberg/pull/5029#discussion_r1095249353
##
flink/v1.16/flink/src/main/java/org/apache/iceberg/flink/source/StreamingMonitorFunction.java:
##
@@ -124,11 +126,33 @@ public void initializeState(FunctionInitia
jackye1995 commented on PR #5029:
URL: https://github.com/apache/iceberg/pull/5029#issuecomment-1414586011
@stevenzwu since you are reviewing #6660, could you also take a look at this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
ajantha-bhat commented on PR #6695:
URL: https://github.com/apache/iceberg/pull/6695#issuecomment-1414692489
> Thanks, @ajantha-bhat! I merged this. Would you mind following up with
cherry-picks to other versions?
Thanks for merging. Today I will work on backporting this PR to other s
lurnagao commented on issue #3127:
URL: https://github.com/apache/iceberg/issues/3127#issuecomment-1414694746
the same problem by using hivecli(2.3.7) + mr + insert into
iceberg_table(0.13.2)
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
1001 - 1100 of 87090 matches
Mail list logo
