RussellSpitzer commented on code in PR #6682: URL: https://github.com/apache/iceberg/pull/6682#discussion_r1095013112
########## spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/actions/BaseSparkAction.java: ########## @@ -253,6 +257,39 @@ protected DeleteSummary deleteFiles( return summary; } + protected DeleteSummary deleteFiles( + Consumer<Iterable<String>> bulkDeleteFunc, Iterator<FileInfo> files) { + DeleteSummary summary = new DeleteSummary(); + Iterator<List<FileInfo>> groupedIterator = Iterators.partition(files, DELETE_GROUP_SIZE); + + Tasks.foreach(groupedIterator) + .suppressFailureWhenFinished() + .run( + fileList -> { + Map<String, List<FileInfo>> filesByType = + fileList.stream().collect(Collectors.groupingBy(FileInfo::getType)); + filesByType.entrySet().stream() + .forEach( + entry -> { + List<String> pathsToDelete = Review Comment: Sure I wasn't aware of this class -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org