dimas-b commented on code in PR #6712:
URL: https://github.com/apache/iceberg/pull/6712#discussion_r1094829567
##########
nessie/src/test/java/org/apache/iceberg/nessie/TestNamespace.java:
##########
@@ -73,6 +77,48 @@ public void testListNamespaces() {
Assertions.assertThat(namespaces).isNotNull().hasSize(2);
}
+ @Test
+ @NessieApiVersions(versions = NessieApiVersion.V1)
+ public void testNamespacesWithV1Api() {
+ createNamespacesAndTables();
+
+ testListTables();
+
+ List<Namespace> namespaces;
+ namespaces = catalog.listNamespaces(Namespace.of("foo"));
+ // NessieApiV1 should include both implicit and explicit namespaces
+ Assertions.assertThat(namespaces)
+ .containsExactlyInAnyOrder(Namespace.of("foo"), Namespace.of("foo",
"bar"));
+ }
+
+ @Test
+ @NessieApiVersions(versions = NessieApiVersion.V2)
+ public void testNamespacesWithV2Api() {
Review Comment:
Would it be more readable if we had a common test that works for both API
versions and validates the main namespace functionality and separate tests for
v1/v2 for validating the handling of "implicit" namespaces?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
