Fokko commented on code in PR #6482:
URL: https://github.com/apache/iceberg/pull/6482#discussion_r1094693759
##########
api/src/main/java/org/apache/iceberg/PartitionSpec.java:
##########
@@ -440,7 +440,7 @@ public Builder year(String sourceName, String targetName) {
sourceColumn.fieldId(),
nextFieldId(),
targetName,
- Transforms.year(sourceColumn.type()));
Review Comment:
I'm hesitant to remove those because then there is a situation where we
don't know the `sourceColumn`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
