jackye1995 commented on code in PR #5029:
URL: https://github.com/apache/iceberg/pull/5029#discussion_r1095248368
##########
flink/v1.16/flink/src/main/java/org/apache/iceberg/flink/source/FlinkSplitPlanner.java:
##########
@@ -86,10 +86,18 @@ static CloseableIterable<CombinedScanTask> planTasks(
IncrementalAppendScan scan = table.newIncrementalAppendScan();
scan = refineScanWithBaseConfigs(scan, context, workerPool);
+ if (context.startTag() != null && table.snapshot(context.startTag()) !=
null) {
Review Comment:
I think we probably need to verify that user only sets one of
`START_SNAPSHOT_ID` and `START_TAG`, instead of both. Also the same for end
case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
