szehon-ho commented on code in PR #6716:
URL: https://github.com/apache/iceberg/pull/6716#discussion_r1094108930


##########
orc/src/main/java/org/apache/iceberg/orc/OrcIterable.java:
##########
@@ -84,15 +91,18 @@ public CloseableIterator<T> iterator() {
     addCloseable(orcFileReader);
 
     TypeDescription fileSchema = orcFileReader.getSchema();
+    Schema schemaWithoutConstantFields =

Review Comment:
   Previously, schema already pruned without constant columns is passed into 
ORCIterable for its filter logic.
   
   However, this fails here when trying to bind the constant column filters to 
it (as they are not in the schema).  This makes it so that we prune out 
constant columns only when we need it, but we keep original schema for the 
binding.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to