[PR] fix: set key_metadata to Null by default [iceberg-rust]

feniljain opened a new pull request, #800: URL: https://github.com/apache/iceberg-rust/pull/800 ## Issue Resolved Closes #753 ## About - Converted Manifest spec's `key_metadata` field to be `Option` instead of just `Vec` - Updated tests to reflect the same - Ran

Re: [PR] fix: wrong compute of partitions in manifest [iceberg-rust]

Xuanwo commented on code in PR #794: URL: https://github.com/apache/iceberg-rust/pull/794#discussion_r1884853758 ## crates/iceberg/src/spec/manifest.rs: ## @@ -128,7 +130,61 @@ pub struct ManifestWriter { key_metadata: Vec, -field_summary: HashMap, +partitions:

Re: [PR] Doc: Add staus page for different implementations. [iceberg]

liurenjie1024 commented on code in PR #11772: URL: https://github.com/apache/iceberg/pull/11772#discussion_r1884789740 ## site/docs/status.md: ## @@ -0,0 +1,362 @@ +--- +title: "Implementation Status" +--- + + +# Implementations Status + +Apache iceberg now has implementations o

Re: [PR] fix: gurantee the deserialize order of struct is same as the struct type [iceberg-rust]

ZENOTME commented on code in PR #795: URL: https://github.com/apache/iceberg-rust/pull/795#discussion_r1884873126 ## crates/iceberg/src/spec/values.rs: ## @@ -3439,11 +3443,13 @@ mod tests { "bar".to_string(), ))), None, +

[PR] fix(catalog/rest): Ensure token been reused correctly [iceberg-rust]

Xuanwo opened a new pull request, #801: URL: https://github.com/apache/iceberg-rust/pull/801 Fix https://github.com/apache/iceberg-rust/issues/791 I discovered that we were not reusing tokens correctly, which could result in sending an unexpectedly high number of token authentication

Re: [PR] fix: wrong compute of partitions in manifest [iceberg-rust]

ZENOTME commented on code in PR #794: URL: https://github.com/apache/iceberg-rust/pull/794#discussion_r1884874229 ## crates/iceberg/src/spec/manifest.rs: ## @@ -128,7 +130,61 @@ pub struct ManifestWriter { key_metadata: Vec, -field_summary: HashMap, +partitions:

Re: [PR] fix: wrong compute of partitions in manifest [iceberg-rust]

ZENOTME commented on code in PR #794: URL: https://github.com/apache/iceberg-rust/pull/794#discussion_r1884917390 ## crates/iceberg/src/spec/manifest.rs: ## @@ -128,7 +130,61 @@ pub struct ManifestWriter { key_metadata: Vec, -field_summary: HashMap, +partitions:

Re: [PR] fix: wrong compute of partitions in manifest [iceberg-rust]

ZENOTME commented on PR #794: URL: https://github.com/apache/iceberg-rust/pull/794#issuecomment-2542949738 Thanks @Xuanwo's suggestion to make the code more clear! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] fix: wrong compute of partitions in manifest [iceberg-rust]

Xuanwo commented on code in PR #794: URL: https://github.com/apache/iceberg-rust/pull/794#discussion_r1884928592 ## crates/iceberg/src/spec/manifest.rs: ## @@ -128,7 +130,61 @@ pub struct ManifestWriter { key_metadata: Vec, -field_summary: HashMap, +partitions:

Re: [PR] fix: wrong compute of partitions in manifest [iceberg-rust]

Xuanwo merged PR #794: URL: https://github.com/apache/iceberg-rust/pull/794 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.a

Re: [PR] Add basic CI to build iceberg and example [iceberg-cpp]

Fokko merged PR #7: URL: https://github.com/apache/iceberg-cpp/pull/7 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.

Re: [PR] Add basic CI to build iceberg and example [iceberg-cpp]

Fokko commented on PR #7: URL: https://github.com/apache/iceberg-cpp/pull/7#issuecomment-2541493436 Thanks @raulcd for the PR and thanks @wgtmac @gaborkaszab @pitrou for reviewing. It seems like most of us are in agreement, and we can always fine-tune later. I've merged this so this won't b

Re: [PR] Add CMake format [iceberg-cpp]

gaborkaszab commented on PR #5: URL: https://github.com/apache/iceberg-cpp/pull/5#issuecomment-2541485775 > Make sense, I will try to find some gh actions that are fit for these tasks, maybe after https://github.com/apache/iceberg-cpp/pull/7 merged. Sounds great, @zhjwpku ! Also so

Re: [PR] add Status data structure [iceberg-cpp]

zhjwpku commented on PR #8: URL: https://github.com/apache/iceberg-cpp/pull/8#issuecomment-2541489280 > Also @zhjwpku can you make sure you proof-read your PR description? There are spell checkers that can help. Sorry about the inconvenience, will be careful in the future. -- This

Re: [PR] Add plan tasks for TableScan [iceberg-python]

kevinjqliu commented on code in PR #1427: URL: https://github.com/apache/iceberg-python/pull/1427#discussion_r1884198201 ## pyiceberg/table/__init__.py: ## @@ -191,6 +193,15 @@ class TableProperties: DELETE_MODE_MERGE_ON_READ = "merge-on-read" DELETE_MODE_DEFAULT = DEL

Re: [PR] IO Implementation using Go CDK [iceberg-go]

loicalleyne commented on PR #176: URL: https://github.com/apache/iceberg-go/pull/176#issuecomment-2541868880 [s3.UsePathStyle](https://pkg.go.dev/github.com/aws/aws-sdk-go-v2/service/s3#Options.UsePathStyle ) ``` // Allows you to enable the client to use path-style addressing, i.e.,

Re: [I] ParallelIterable is deadlocking and is generally really complicated [iceberg]

findepi commented on issue #11768: URL: https://github.com/apache/iceberg/issues/11768#issuecomment-2541606235 Good writeup thanks for filing this issue @sopel39. How hard would be to do the long term fix? @rdblue you usually have opinions on `ParallelIterable`. do you have one this

Re: [I] Encountering `429 Too Many Requests` error every time when accessing Snowflake's Polaris catalog [iceberg-rust]

Xuanwo commented on issue #791: URL: https://github.com/apache/iceberg-rust/issues/791#issuecomment-2541691960 More detailed error message after test with https://github.com/apache/iceberg-rust/pull/793 ``` 1107=> Iceberg catalog load failed: ReadTableDataError. Code: 1107, Text

Re: [PR] Add Dependabot for GitHub Actions [iceberg-cpp]

wgtmac commented on code in PR #11: URL: https://github.com/apache/iceberg-cpp/pull/11#discussion_r1884111642 ## .github/dependabot.yml: ## @@ -0,0 +1,26 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTIC

Re: [PR] Add CMake format [iceberg-cpp]

gaborkaszab commented on PR #5: URL: https://github.com/apache/iceberg-cpp/pull/5#issuecomment-2541459840 One general question: I see the command in the description that leverages this change to format CMake files. It's up to the contributor to run this manually, and I'm wondering if it mak

[PR] Fix ParallelIterable deadlock [iceberg]

sopel39 opened a new pull request, #11781: URL: https://github.com/apache/iceberg/pull/11781 It was observed that with high concurrency/high workload scenario cluster deadlocks due to manifest readers waiting for connection from S3 pool. Specifically, ManifestGroup#plan will create Ma

Re: [PR] Fix ParallelIterable deadlock [iceberg]

sopel39 commented on PR #11781: URL: https://github.com/apache/iceberg/pull/11781#issuecomment-2541648505 cc @findepi @RussellSpitzer @osscm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] Add license checker [iceberg-cpp]

wgtmac commented on code in PR #10: URL: https://github.com/apache/iceberg-cpp/pull/10#discussion_r1884080056 ## .github/workflows/license_check.yml: ## @@ -0,0 +1,26 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See

Re: [PR] fix: gurantee the deserialize order of struct is same as the struct type [iceberg-rust]

ZENOTME commented on PR #795: URL: https://github.com/apache/iceberg-rust/pull/795#issuecomment-2541792027 cc @liurenjie1024 @Fokko @Xuanwo @sdd -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[PR] fix: gurantee the deserialize order of struct is same as the struct type [iceberg-rust]

ZENOTME opened a new pull request, #795: URL: https://github.com/apache/iceberg-rust/pull/795 We should deserialize according to order of struct type rather than the deserialize value. -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

Re: [I] Add new poetry extras for rest sigv4 [iceberg-python]

kevinjqliu closed issue #1405: Add new poetry extras for rest sigv4 URL: https://github.com/apache/iceberg-python/issues/1405 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Add CMake format [iceberg-cpp]

pitrou commented on PR #5: URL: https://github.com/apache/iceberg-cpp/pull/5#issuecomment-2541795231 > nit: should we put cmake-format.py into a sub-folder like `scripts` or something? It's not a script, it's a config file for the `cmake-format` utility (yes, it's confusing and awkwa

Re: [PR] Add CMake format [iceberg-cpp]

pitrou commented on PR #5: URL: https://github.com/apache/iceberg-cpp/pull/5#issuecomment-2541796460 > > Make sense, I will try to find some gh actions that are fit for these tasks, maybe after #7 merged. > > Sounds great, @zhjwpku ! Also some build script that people can run locally

Re: [PR] add .gitignore [iceberg-cpp]

raulcd commented on code in PR #9: URL: https://github.com/apache/iceberg-cpp/pull/9#discussion_r1884174779 ## .gitignore: ## @@ -0,0 +1,18 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distrib

Re: [I] Compatibility Issue with pydantic and annotated-types in pyiceberg 0.8.1 [iceberg-python]

kevinjqliu commented on issue #1418: URL: https://github.com/apache/iceberg-python/issues/1418#issuecomment-2541801507 Hi @pawansanz, I've also encountered this issue before. In my case, it was due to the different library versions on my laptop. A way to debug is to ensure that the `pyt

Re: [I] PyIceberg appending data creates snapshots incompatible with Athena/Spark [iceberg-python]

kevinjqliu commented on issue #1424: URL: https://github.com/apache/iceberg-python/issues/1424#issuecomment-2541805668 hi @Samreay thanks for reporting this issue! Very odd that its 1+MAX_VALUE. I took a look at the write path and didn't see anything that stood put that would cause

Re: [PR] IO Implementation using Go CDK [iceberg-go]

loicalleyne commented on PR #176: URL: https://github.com/apache/iceberg-go/pull/176#issuecomment-2541810573 My understanding is that it's just another property to pass in `props`. Would also have to add it as a recognized property/constant in io/s3.go I should think. -- This is an auto

Re: [PR] fix: field id in name mapping should be optional [iceberg-python]

kevinjqliu commented on PR #1426: URL: https://github.com/apache/iceberg-python/pull/1426#issuecomment-2541812934 @barronw looks like theres a linter issue, could you try to run `make lint`? -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] add .gitignore [iceberg-cpp]

raulcd commented on code in PR #9: URL: https://github.com/apache/iceberg-cpp/pull/9#discussion_r1883942550 ## .gitignore: ## @@ -0,0 +1 @@ +build/ Review Comment: We can also add a license following this format, as seen here: https://github.com/apache/arrow/blob/main/.giti

Re: [PR] Add CMake format [iceberg-cpp]

zhjwpku commented on PR #5: URL: https://github.com/apache/iceberg-cpp/pull/5#issuecomment-2541476566 > One general question: I see the command in the description that leverages this change to format CMake files. It's up to the contributor to run this manually, and I'm wondering if it makes

Re: [PR] Add Dependabot for GitHub Actions [iceberg-cpp]

zhjwpku commented on code in PR #11: URL: https://github.com/apache/iceberg-cpp/pull/11#discussion_r1883987957 ## .github/dependabot.yml: ## @@ -0,0 +1,26 @@ +# Review Comment: It seems we don't have this leading `#` and the trailing `#` in other license blocks that use `#`

Re: [PR] Remove unneeded partitoning [iceberg-python]

kevinjqliu commented on PR #1417: URL: https://github.com/apache/iceberg-python/pull/1417#issuecomment-2541817185 Looks like some tests are failing due to number of partitions being hardcoded in tests ``` === short test summary info ===

Re: [PR] Fix `Table.scan` to enable case sensitive argument [iceberg-python]

kevinjqliu commented on code in PR #1423: URL: https://github.com/apache/iceberg-python/pull/1423#discussion_r1884193700 ## tests/table/test_init.py: ## @@ -310,6 +310,19 @@ def test_table_scan_row_filter(table_v2: Table) -> None: assert scan.filter(EqualTo("x", 10)).filter

Re: [PR] Core: Add missing REST endpoint definitions [iceberg]

ajreid21 commented on code in PR #11756: URL: https://github.com/apache/iceberg/pull/11756#discussion_r1884197553 ## core/src/main/java/org/apache/iceberg/rest/Endpoint.java: ## @@ -46,6 +46,8 @@ public class Endpoint { Endpoint.create("POST", ResourcePaths.V1_NAMESPACE_P

Re: [PR] Core: Add missing REST endpoint definitions [iceberg]

ajreid21 commented on PR #11756: URL: https://github.com/apache/iceberg/pull/11756#issuecomment-2541836163 @nastra I addressed the comments and added the new checks if you want to take another look. Thanks. -- This is an automated message from the Apache Git Service. To respond to the mes

Re: [PR] Core: Add missing REST endpoint definitions [iceberg]

ajreid21 commented on code in PR #11756: URL: https://github.com/apache/iceberg/pull/11756#discussion_r1884198902 ## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ## @@ -138,11 +138,13 @@ public class RESTSessionCatalog extends BaseViewSessionCatalog

Re: [PR] add Status data structure [iceberg-cpp]

zhjwpku commented on code in PR #8: URL: https://github.com/apache/iceberg-cpp/pull/8#discussion_r1883973801 ## CMakeLists.txt: ## @@ -56,6 +64,11 @@ add_subdirectory(api) add_subdirectory(src) if(ICEBERG_BUILD_TESTS) + fetchcontent_declare(googletest Review Comment: Ye

Re: [PR] add Status data structure [iceberg-cpp]

wgtmac commented on code in PR #8: URL: https://github.com/apache/iceberg-cpp/pull/8#discussion_r1884103063 ## api/iceberg/status.h: ## @@ -0,0 +1,435 @@ +// Copyright (c) 2011 The LevelDB Authors. All rights reserved. +// Use of this source code is governed by a BSD-style licen

[PR] fix: wrong compute of partitions in manifest [iceberg-rust]

ZENOTME opened a new pull request, #794: URL: https://github.com/apache/iceberg-rust/pull/794 Our computing way of partitions in the manifest is wrong. It should be a list of field summaries for each partition field in the spec. Each field in the list corresponds to a field in the manifest

Re: [PR] add Status data structure [iceberg-cpp]

pitrou commented on code in PR #8: URL: https://github.com/apache/iceberg-cpp/pull/8#discussion_r1884150547 ## api/iceberg/util/string_builder.h: ## @@ -0,0 +1,84 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. S

Re: [PR] add .gitignore [iceberg-cpp]

pitrou commented on code in PR #9: URL: https://github.com/apache/iceberg-cpp/pull/9#discussion_r1884149504 ## .gitignore: ## @@ -0,0 +1,18 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distrib

Re: [PR] add Status data structure [iceberg-cpp]

pitrou commented on code in PR #8: URL: https://github.com/apache/iceberg-cpp/pull/8#discussion_r1884150163 ## CMakeLists.txt: ## @@ -56,6 +64,11 @@ add_subdirectory(api) add_subdirectory(src) if(ICEBERG_BUILD_TESTS) + fetchcontent_declare(googletest Review Comment: Per

Re: [PR] add Status data structure [iceberg-cpp]

pitrou commented on code in PR #8: URL: https://github.com/apache/iceberg-cpp/pull/8#discussion_r1884153144 ## api/iceberg/status.h: ## @@ -0,0 +1,435 @@ +// Copyright (c) 2011 The LevelDB Authors. All rights reserved. +// Use of this source code is governed by a BSD-style licen

Re: [PR] fix: wrong compute of partitions in manifest [iceberg-rust]

ZENOTME commented on PR #794: URL: https://github.com/apache/iceberg-rust/pull/794#issuecomment-2541768726 cc @liurenjie1024 @Fokko @Xuanwo @sdd -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] IO Implementation using Go CDK [iceberg-go]

zeroshade commented on PR #176: URL: https://github.com/apache/iceberg-go/pull/176#issuecomment-2541769470 @loicalleyne I haven't dug too far into the blob code, is it a relatively easy fix to handle that `s3ForcePathStyle`? -- This is an automated message from the Apache Git Service. To

Re: [I] Decouple building and serialization [iceberg-rust]

Sl1mb0 commented on issue #778: URL: https://github.com/apache/iceberg-rust/issues/778#issuecomment-2541752081 I should clarify: I would be happy do this work at some point but would like to know if it would be accepted. -- This is an automated message from the Apache Git Service. To resp

Re: [PR] add .gitignore [iceberg-cpp]

pitrou commented on code in PR #9: URL: https://github.com/apache/iceberg-cpp/pull/9#discussion_r1884148649 ## .gitignore: ## @@ -0,0 +1,18 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distrib

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

ShyamalaGowri commented on PR #11577: URL: https://github.com/apache/iceberg/pull/11577#issuecomment-2541761879 @ChaladiMohanVamsi Can you help to understand how you would initialize ADLSFileIO with these changes. Priorly we can call initialize with the SAS token or account key and initiali

Re: [I] [Request] Area of Improvements for Documentation [iceberg-python]

kevinjqliu commented on issue #1407: URL: https://github.com/apache/iceberg-python/issues/1407#issuecomment-2541780503 @jeppe-dos thanks for reporting this! Is this something you would like to contribute? -- This is an automated message from the Apache Git Service. To respond to the mes

[PR] Add Dependabot for GitHub Actions [iceberg-cpp]

Fokko opened a new pull request, #11: URL: https://github.com/apache/iceberg-cpp/pull/11 I love dependabot <3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

Re: [PR] Add license checker [iceberg-cpp]

zhjwpku commented on code in PR #10: URL: https://github.com/apache/iceberg-cpp/pull/10#discussion_r1883963124 ## dev/check-license: ## @@ -0,0 +1,83 @@ +#!/usr/bin/env bash + +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements

Re: [PR] REST: Don't reset snapshotLog when replacing table [iceberg]

nastra commented on code in PR #11779: URL: https://github.com/apache/iceberg/pull/11779#discussion_r1884087249 ## core/src/main/java/org/apache/iceberg/MetadataUpdateParser.java: ## @@ -548,7 +552,8 @@ private static MetadataUpdate readSetSnapshotRef(JsonNode node) { priv

Re: [PR] REST: Don't reset snapshotLog when replacing table [iceberg]

nastra commented on code in PR #11779: URL: https://github.com/apache/iceberg/pull/11779#discussion_r1884088464 ## core/src/main/java/org/apache/iceberg/MetadataUpdateParser.java: ## @@ -417,6 +420,7 @@ private static void writeSetSnapshotRef(MetadataUpdate.SetSnapshotRef updat

Re: [PR] add Status data structure [iceberg-cpp]

wgtmac commented on code in PR #8: URL: https://github.com/apache/iceberg-cpp/pull/8#discussion_r1884094679 ## api/iceberg/util/string_builder.h: ## @@ -0,0 +1,84 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. S

Re: [PR] add Status data structure [iceberg-cpp]

wgtmac commented on code in PR #8: URL: https://github.com/apache/iceberg-cpp/pull/8#discussion_r1884105549 ## src/common/CMakeLists.txt: ## @@ -0,0 +1,28 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE

Re: [I] Data loss bug in MergeIntoCommand [iceberg]

BsoBird commented on issue #11765: URL: https://github.com/apache/iceberg/issues/11765#issuecomment-2541708695 @RussellSpitzer Sir. I am using Spark version 3.5.1, and the Iceberg version is 1.7.1/1.6.1. Sql: ``` merge into target_iceberg_table t using ( select

[PR] fix: day transform compute [iceberg-rust]

ZENOTME opened a new pull request, #796: URL: https://github.com/apache/iceberg-rust/pull/796 https://github.com/apache/iceberg-rust/pull/479 change the result type from int to date. And we should also change the computed result for this, otherwise, it will cause the inconsistent error. E.g

Re: [PR] fix: day transform compute [iceberg-rust]

ZENOTME commented on PR #796: URL: https://github.com/apache/iceberg-rust/pull/796#issuecomment-2541879394 cc @liurenjie1024 @Fokko @Xuanwo @sdd -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] feat: expose _serde::DataFile [iceberg-rust]

ZENOTME commented on PR #797: URL: https://github.com/apache/iceberg-rust/pull/797#issuecomment-2541894721 cc @liurenjie1024 @Xuanwo @Fokko @sdd -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [I] Discussion: make DataFile Serializable && Deserializable [iceberg-rust]

ZENOTME commented on issue #774: URL: https://github.com/apache/iceberg-rust/issues/774#issuecomment-2541894094 > Hey @ZENOTME thanks for raising this. > > Technically the `Datafile` is already serializable, you can encode it into Iceberg Avro :) I know how this works in Java and Pyth

[PR] [INFRA] Remove sha256 [iceberg-go]

kevinjqliu opened a new pull request, #226: URL: https://github.com/apache/iceberg-go/pull/226 Sha512 is enough, Sha256 is not necessary devlist: https://lists.apache.org/thread/rsl3rj9rcqvchb8dqr8tjky97rt5pm22 Part of #204 -- This is an automated message from the Apache Git Ser

Re: [I] [Investigate] Whether `data_files` metadata table requires both pyarrow and s3fs [iceberg-python]

kevinjqliu commented on issue #1317: URL: https://github.com/apache/iceberg-python/issues/1317#issuecomment-2541919224 Hi @jiakai-li thanks for looking into this! > It was run with the s3fs module removed from the environment, which runs ok: I think you'd want to remove `pyarrow`

[PR] feat: support to append delete type data file [iceberg-rust]

ZENOTME opened a new pull request, #798: URL: https://github.com/apache/iceberg-rust/pull/798 This PR support to support to append delete type data file -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] feat: support to append delete type data file [iceberg-rust]

ZENOTME commented on PR #798: URL: https://github.com/apache/iceberg-rust/pull/798#issuecomment-2541922752 cc @liurenjie1024 @Xuanwo @Fokko @sdd -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [I] API table.scan does not conform to Iceberg spec for identity partition columns [iceberg-python]

gabeiglio commented on issue #1401: URL: https://github.com/apache/iceberg-python/issues/1401#issuecomment-2542474285 Im open for feedback but as I investigated this issue im inclined that the fix would need to be in [_task_to_record_batches](https://github.com/apache/iceberg-python/blob/a

Re: [PR] Spark 3.5: Fix comment and assertion mismatch in PartitionedWritesTestBase/TestRewritePositionDeleteFilesAction [iceberg]

szehon-ho commented on code in PR #11748: URL: https://github.com/apache/iceberg/pull/11748#discussion_r1884599985 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewritePositionDeleteFilesAction.java: ## @@ -275,7 +275,7 @@ public void testRewriteFilter()

Re: [PR] add Status data structure [iceberg-cpp]

zhjwpku commented on code in PR #8: URL: https://github.com/apache/iceberg-cpp/pull/8#discussion_r1884656709 ## src/common/CMakeLists.txt: ## @@ -0,0 +1,28 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE

Re: [PR] add Status data structure [iceberg-cpp]

zhjwpku commented on code in PR #8: URL: https://github.com/apache/iceberg-cpp/pull/8#discussion_r1884658885 ## api/iceberg/status.h: ## @@ -0,0 +1,435 @@ +// Copyright (c) 2011 The LevelDB Authors. All rights reserved. +// Use of this source code is governed by a BSD-style lice

Re: [PR] Spark: Relativize in-memory paths for data file and rewritable delete file locations [iceberg]

github-actions[bot] commented on PR #11525: URL: https://github.com/apache/iceberg/pull/11525#issuecomment-2542578530 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pul

Re: [PR] [WIP][Core] Restrict adding column of StructType with Empty Fields [iceberg]

singhpk234 commented on PR #11755: URL: https://github.com/apache/iceberg/pull/11755#issuecomment-2542608870 interesting cases @ebyhr ! [1] Struct of Struct and the inner struct is empty [2] The above handles only add column, we can land this situation for dropping to the column

Re: [PR] API: add hashcode cache in StructType [iceberg]

singhpk234 commented on PR #11764: URL: https://github.com/apache/iceberg/pull/11764#issuecomment-2542605844 > Pre-execution Preparation Time: the time interval from the first table load to the start of the first stage execution Scan Spec Time: added a timer to the method SparkPartitionin

Re: [PR] API: add hashcode cache in StructType [iceberg]

singhpk234 commented on code in PR #11764: URL: https://github.com/apache/iceberg/pull/11764#discussion_r1884691655 ## api/src/main/java/org/apache/iceberg/types/Types.java: ## @@ -824,7 +827,10 @@ public boolean equals(Object o) { @Override public int hashCode() { -

Re: [I] Data loss bug in MergeIntoCommand [iceberg]

BsoBird commented on issue #11765: URL: https://github.com/apache/iceberg/issues/11765#issuecomment-2542688203 @RussellSpitzer Sir.If you have time, please review this PR for me. I believe we need to warn users against doing this in the documentation. https://github.com/apache/iceberg

Re: [PR] Doc: Add staus page for different implementations. [iceberg]

liurenjie1024 commented on code in PR #11772: URL: https://github.com/apache/iceberg/pull/11772#discussion_r1884744385 ## site/docs/status.md: ## @@ -0,0 +1,362 @@ +--- +title: "Implementation Status" +--- + + +# Implementations Status + +Apache iceberg now has implementations o

Re: [PR] Doc: Add staus page for different implementations. [iceberg]

liurenjie1024 commented on code in PR #11772: URL: https://github.com/apache/iceberg/pull/11772#discussion_r1884744299 ## site/docs/status.md: ## @@ -0,0 +1,362 @@ +--- +title: "Implementation Status" +--- + + +# Implementations Status + +Apache iceberg now has implementations o

Re: [PR] Doc: Add staus page for different implementations. [iceberg]

sungwy commented on code in PR #11772: URL: https://github.com/apache/iceberg/pull/11772#discussion_r1884751449 ## site/docs/status.md: ## @@ -0,0 +1,362 @@ +--- +title: "Implementation Status" +--- + + +# Implementations Status + +Apache iceberg now has implementations of the i

Re: [PR] Doc: Add staus page for different implementations. [iceberg]

sungwy commented on code in PR #11772: URL: https://github.com/apache/iceberg/pull/11772#discussion_r1884751449 ## site/docs/status.md: ## @@ -0,0 +1,362 @@ +--- +title: "Implementation Status" +--- + + +# Implementations Status + +Apache iceberg now has implementations of the i

Re: [PR] Doc: Add staus page for different implementations. [iceberg]

liurenjie1024 commented on code in PR #11772: URL: https://github.com/apache/iceberg/pull/11772#discussion_r1884751636 ## site/docs/status.md: ## @@ -0,0 +1,362 @@ +--- +title: "Implementation Status" +--- + + +# Implementations Status + +Apache iceberg now has implementations o

Re: [PR] feat: support create partition table for non REST catalog [iceberg-rust]

FANNG1 closed pull request #577: feat: support create partition table for non REST catalog URL: https://github.com/apache/iceberg-rust/pull/577 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] Doc: Add staus page for different implementations. [iceberg]

sungwy commented on code in PR #11772: URL: https://github.com/apache/iceberg/pull/11772#discussion_r1884748942 ## site/docs/status.md: ## @@ -0,0 +1,362 @@ +--- +title: "Implementation Status" +--- + + +# Implementations Status + +Apache iceberg now has implementations of the i

Re: [PR] Doc: Add staus page for different implementations. [iceberg]

sungwy commented on code in PR #11772: URL: https://github.com/apache/iceberg/pull/11772#discussion_r1884748942 ## site/docs/status.md: ## @@ -0,0 +1,362 @@ +--- +title: "Implementation Status" +--- + + +# Implementations Status + +Apache iceberg now has implementations of the i

Re: [PR] Doc: Add staus page for different implementations. [iceberg]

sungwy commented on code in PR #11772: URL: https://github.com/apache/iceberg/pull/11772#discussion_r1884750217 ## site/docs/status.md: ## @@ -0,0 +1,362 @@ +--- +title: "Implementation Status" +--- + + +# Implementations Status + +Apache iceberg now has implementations of the i

Re: [PR] Doc: Add staus page for different implementations. [iceberg]

sungwy commented on code in PR #11772: URL: https://github.com/apache/iceberg/pull/11772#discussion_r1884748942 ## site/docs/status.md: ## @@ -0,0 +1,362 @@ +--- +title: "Implementation Status" +--- + + +# Implementations Status + +Apache iceberg now has implementations of the i

Re: [PR] Doc: Add staus page for different implementations. [iceberg]

liurenjie1024 commented on code in PR #11772: URL: https://github.com/apache/iceberg/pull/11772#discussion_r1884751870 ## site/docs/status.md: ## @@ -0,0 +1,362 @@ +--- +title: "Implementation Status" +--- + + +# Implementations Status + +Apache iceberg now has implementations o

Re: [PR] Doc: Add staus page for different implementations. [iceberg]

liurenjie1024 commented on code in PR #11772: URL: https://github.com/apache/iceberg/pull/11772#discussion_r1884751807 ## site/docs/status.md: ## @@ -0,0 +1,362 @@ +--- +title: "Implementation Status" +--- + + +# Implementations Status + +Apache iceberg now has implementations o

Re: [PR] Doc: Add staus page for different implementations. [iceberg]

sungwy commented on code in PR #11772: URL: https://github.com/apache/iceberg/pull/11772#discussion_r1884751449 ## site/docs/status.md: ## @@ -0,0 +1,362 @@ +--- +title: "Implementation Status" +--- + + +# Implementations Status + +Apache iceberg now has implementations of the i

Re: [PR] Doc: Add staus page for different implementations. [iceberg]

liurenjie1024 commented on PR #11772: URL: https://github.com/apache/iceberg/pull/11772#issuecomment-2542710889 > Given iceberg-cpp is in development, should we add the columns for it even though it will be N for everything right now? I'm open to this, but currently this page lists ca

Re: [PR] Doc: Add staus page for different implementations. [iceberg]

sungwy commented on code in PR #11772: URL: https://github.com/apache/iceberg/pull/11772#discussion_r1884750217 ## site/docs/status.md: ## @@ -0,0 +1,362 @@ +--- +title: "Implementation Status" +--- + + +# Implementations Status + +Apache iceberg now has implementations of the i

Re: [PR] Doc: Add staus page for different implementations. [iceberg]

liurenjie1024 commented on code in PR #11772: URL: https://github.com/apache/iceberg/pull/11772#discussion_r1884756239 ## site/docs/status.md: ## @@ -0,0 +1,362 @@ +--- +title: "Implementation Status" +--- + + +# Implementations Status + +Apache iceberg now has implementations o

Re: [PR] Doc: Add staus page for different implementations. [iceberg]

sungwy commented on code in PR #11772: URL: https://github.com/apache/iceberg/pull/11772#discussion_r1884752146 ## site/docs/status.md: ## @@ -0,0 +1,362 @@ +--- +title: "Implementation Status" +--- + + +# Implementations Status + +Apache iceberg now has implementations of the i

Re: [PR] Doc: Add staus page for different implementations. [iceberg]

liurenjie1024 commented on code in PR #11772: URL: https://github.com/apache/iceberg/pull/11772#discussion_r1884757874 ## site/docs/status.md: ## @@ -0,0 +1,362 @@ +--- +title: "Implementation Status" +--- + + +# Implementations Status + +Apache iceberg now has implementations o

Re: [PR] Doc: Add staus page for different implementations. [iceberg]

liurenjie1024 commented on PR #11772: URL: https://github.com/apache/iceberg/pull/11772#issuecomment-2542722986 > For example, I'm missing the [procedures](https://iceberg.apache.org/docs/latest/spark-procedures/), such as expire-snapshots, compaction etc. The reason I didn't add thi

<    1   2