singhpk234 commented on code in PR #11764:
URL: https://github.com/apache/iceberg/pull/11764#discussion_r1884691655
##########
api/src/main/java/org/apache/iceberg/types/Types.java:
##########
@@ -824,7 +827,10 @@ public boolean equals(Object o) {
@Override
public int hashCode() {
- return Objects.hash(NestedField.class, Arrays.hashCode(fields));
+ if (hashCode == NO_HASHCODE) {
+ hashCode = Objects.hash(NestedField.class, Arrays.hashCode(fields));
+ }
+ return hashCode;
Review Comment:
can this have a multi-threaded access ? if yes can we have double check
locking ? to avoid recompute
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
