zhjwpku commented on PR #5: URL: https://github.com/apache/iceberg-cpp/pull/5#issuecomment-2541476566
> One general question: I see the command in the description that leverages this change to format CMake files. It's up to the contributor to run this manually, and I'm wondering if it makes sense to introduce some build script that runs this, the clang format, and also compiles the project. We'd have more guarantee then that these format requirements are met Make sense, I will try to find some gh actions that are fit for these tasks, maybe after #7 merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
