zhjwpku commented on code in PR #8: URL: https://github.com/apache/iceberg-cpp/pull/8#discussion_r1883973801
########## CMakeLists.txt: ########## @@ -56,6 +64,11 @@ add_subdirectory(api) add_subdirectory(src) if(ICEBERG_BUILD_TESTS) + fetchcontent_declare(googletest Review Comment: Yeah, I see that Catch2 has TDD and BDD, which is better, I will do some work and find out which one fits us better. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org