nastra commented on code in PR #11779:
URL: https://github.com/apache/iceberg/pull/11779#discussion_r1884088464


##########
core/src/main/java/org/apache/iceberg/MetadataUpdateParser.java:
##########
@@ -417,6 +420,7 @@ private static void 
writeSetSnapshotRef(MetadataUpdate.SetSnapshotRef update, Js
   private static void writeRemoveSnapshotRef(
       MetadataUpdate.RemoveSnapshotRef update, JsonGenerator gen) throws 
IOException {
     gen.writeStringField(REF_NAME, update.name());
+    gen.writeBooleanField(PURGE, update.purge());

Review Comment:
   this is effectively a spec change and would require a vote on the DEV ML + 
updates to the OpenAPI spec



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to