singhpk234 commented on PR #11755: URL: https://github.com/apache/iceberg/pull/11755#issuecomment-2542608870
interesting cases @ebyhr ! [1] Struct of Struct and the inner struct is empty [2] The above handles only add column, we can land this situation for dropping to the column This is what the spec says presently ``` Any struct, including a top-level schema, can evolve through deleting fields, adding new fields, renaming existing fields, reordering existing fields, or promoting a primitive using the valid type promotions. Adding a new field assigns a new ID for that field and for any nested fields. Renaming an existing field must change the name, but not the field ID. Deleting a field removes it from the current schema. Field deletion cannot be rolled back unless the field was nullable or if the current snapshot has not changed ``` All in all the idea of raising this was to let spec enforce these cases such that we don't be in this case where a struct is empty and formats like parquet fail indefinitely. Please let me know your thoughts if you as well allign with this idea -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
