nastra commented on PR #8819:
URL: https://github.com/apache/iceberg/pull/8819#issuecomment-1761008540
@PickBas thanks for working on this. I think it would be great to combine
all changes in a single PR rather than opening 1-file PRs
--
This is an automated message from the Apache Git Se
nastra commented on code in PR #8678:
URL: https://github.com/apache/iceberg/pull/8678#discussion_r1357853053
##
core/src/main/java/org/apache/iceberg/view/BaseMetastoreViewCatalog.java:
##
@@ -161,7 +162,7 @@ private View create(ViewOperations ops) {
.defaultName
nastra commented on code in PR #8678:
URL: https://github.com/apache/iceberg/pull/8678#discussion_r1357855073
##
core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java:
##
@@ -99,7 +100,7 @@ public void basicCreateView() {
.timestampMillis(view.current
liurenjie1024 commented on code in PR #79:
URL: https://github.com/apache/iceberg-rust/pull/79#discussion_r1357853771
##
crates/iceberg/src/spec/partition.rs:
##
@@ -54,6 +56,24 @@ impl PartitionSpec {
pub fn builder() -> PartitionSpecBuilder {
PartitionSpecBuilder
PickBas commented on PR #8819:
URL: https://github.com/apache/iceberg/pull/8819#issuecomment-1761042424
> @PickBas thanks for working on this. I think it would be great to combine
all changes in a single PR rather than opening 1-file PRs
@nastra Thank you for your feedback. I've done
ZENOTME commented on code in PR #79:
URL: https://github.com/apache/iceberg-rust/pull/79#discussion_r1357920808
##
crates/iceberg/src/spec/values.rs:
##
@@ -966,6 +978,547 @@ mod timestamptz {
}
}
+mod serde {
Review Comment:
If `RawLiteral` looks well, I can seperat
ZENOTME commented on code in PR #79:
URL: https://github.com/apache/iceberg-rust/pull/79#discussion_r1357921009
##
crates/iceberg/src/spec/partition.rs:
##
@@ -54,6 +56,24 @@ impl PartitionSpec {
pub fn builder() -> PartitionSpecBuilder {
PartitionSpecBuilder::defa
liurenjie1024 commented on code in PR #62:
URL: https://github.com/apache/iceberg-rust/pull/62#discussion_r1357880510
##
crates/iceberg/src/spec/table_metadata.rs:
##
@@ -93,22 +116,278 @@ pub struct TableMetadata {
/// previous metadata file location should be added to the
amogh-jahagirdar commented on issue #8824:
URL: https://github.com/apache/iceberg/issues/8824#issuecomment-1761134284
Yeah, I'd probably start with making this
https://github.com/apache/iceberg/blob/main/spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRemoveOrphanFilesAct
PickBas closed pull request #8823: Aws: aws/*: replaced .size() > 0 with
isEmpty()
URL: https://github.com/apache/iceberg/pull/8823
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
PickBas closed pull request #8820: Mr: mr/*: replaced .size() > 0 with isEmpty()
URL: https://github.com/apache/iceberg/pull/8820
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
PickBas closed pull request #8818: Delta-lake: delta-lake/*: replaced .size() >
0 with isEmpty()
URL: https://github.com/apache/iceberg/pull/8818
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
PickBas closed pull request #8821: Aliyun: aliyun/*: replaced .size() > 0 with
isEmpty()
URL: https://github.com/apache/iceberg/pull/8821
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
PickBas closed pull request #8817: Hive3: hive3/*: replaced .size() > 0 with
isEmpty()
URL: https://github.com/apache/iceberg/pull/8817
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
PickBas closed pull request #8816: Parquet: parquet/*: replaced .size() > 0
with isEmpty()
URL: https://github.com/apache/iceberg/pull/8816
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
PickBas closed pull request #8815: Data: data/*: replaced .size() > 0 with
isEmpty()
URL: https://github.com/apache/iceberg/pull/8815
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
PickBas closed pull request #8822: Api: api/*: replaced .size() > 0 with
isEmpty()
URL: https://github.com/apache/iceberg/pull/8822
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
PickBas commented on PR #8819:
URL: https://github.com/apache/iceberg/pull/8819#issuecomment-1761167713
@amogh-jahagirdar @nastra @Fokko Done. Now the rest of the modules are
included in this pull request.
--
This is an automated message from the Apache Git Service.
To respond to the mes
chenwyi2 commented on PR #7161:
URL: https://github.com/apache/iceberg/pull/7161#issuecomment-1761169778
Hi @stevenzwu @kengtin this PR can be create too many small files when
parition with dt,hout,minute and bucekt(id), suppose paralisim is 120 and bucke
number is 8, then 15 writes can wri
Fokko commented on PR #8819:
URL: https://github.com/apache/iceberg/pull/8819#issuecomment-1761169780
> If that works for both you and @Fokko, I will surely do that.
I'm open to everything.
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
Fokko commented on code in PR #8819:
URL: https://github.com/apache/iceberg/pull/8819#discussion_r1357986438
##
aws/src/integration/java/org/apache/iceberg/aws/glue/TestGlueCatalogNamespace.java:
##
@@ -105,7 +105,7 @@ public void testNamespaceExists() {
public void testListN
nastra commented on code in PR #8819:
URL: https://github.com/apache/iceberg/pull/8819#discussion_r1358006481
##
aws/src/integration/java/org/apache/iceberg/aws/glue/TestGlueCatalogNamespace.java:
##
@@ -105,7 +105,7 @@ public void testNamespaceExists() {
public void testList
nastra commented on PR #8808:
URL: https://github.com/apache/iceberg/pull/8808#issuecomment-1761210176
@fengjiajie thanks for working on this. Could you please add a test that
reproduces the issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
nastra commented on code in PR #11:
URL: https://github.com/apache/iceberg-go/pull/11#discussion_r1358030118
##
table/metadata.go:
##
@@ -0,0 +1,401 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
nastra commented on code in PR #11:
URL: https://github.com/apache/iceberg-go/pull/11#discussion_r1358030652
##
table/table.go:
##
@@ -0,0 +1,97 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+//
nastra commented on code in PR #11:
URL: https://github.com/apache/iceberg-go/pull/11#discussion_r1358032220
##
table/table.go:
##
@@ -0,0 +1,97 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+//
nastra merged PR #11:
URL: https://github.com/apache/iceberg-go/pull/11
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apach
Fokko commented on code in PR #63:
URL: https://github.com/apache/iceberg-python/pull/63#discussion_r1358033938
##
pyiceberg/manifest.py:
##
@@ -182,6 +182,7 @@ def __repr__(self) -> str:
doc="Splittable offsets",
),
NestedField(field_id=140, name=
amogh-jahagirdar commented on issue #64:
URL: https://github.com/apache/iceberg-python/issues/64#issuecomment-1761229740
Hm yeah I can repro this with a simple test in `table/test_init.py`
```
scan = table.scan(row_filter="x=1 AND y=1 AND z=1")
assert scan.row_filter == And(E
amogh-jahagirdar commented on issue #64:
URL: https://github.com/apache/iceberg-python/issues/64#issuecomment-1761230308
Looking into this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
amogh-jahagirdar commented on issue #64:
URL: https://github.com/apache/iceberg-python/issues/64#issuecomment-1761250090
https://github.com/apache/iceberg-python/blob/main/pyiceberg/expressions/parser.py#L236
this is where it'll skip anything after. I think this needs to combine all
result
nastra commented on code in PR #8808:
URL: https://github.com/apache/iceberg/pull/8808#discussion_r1358102450
##
flink/v1.15/flink/src/test/java/org/apache/iceberg/flink/data/TestFlinkParquetReader.java:
##
@@ -98,6 +100,62 @@ public void testTwoLevelList() throws IOException {
nastra merged PR #8763:
URL: https://github.com/apache/iceberg/pull/8763
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac
Fokko commented on PR #35:
URL: https://github.com/apache/iceberg-python/pull/35#issuecomment-1761321623
@steinsgateted can you pull in the main branch? It looks like that 3.12 is
available: https://github.com/actions/python-versions/releases
--
This is an automated message from the Apach
Fokko merged PR #8819:
URL: https://github.com/apache/iceberg/pull/8819
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apach
Fokko commented on PR #8819:
URL: https://github.com/apache/iceberg/pull/8819#issuecomment-1761324612
Thanks @PickBas for picking this up 🙌 and @nastra and @ajantha-bhat for the
review 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
amogh-jahagirdar opened a new pull request, #65:
URL: https://github.com/apache/iceberg-python/pull/65
Fixes #64 . If there are multiple and/or conditions currently, our
expression parser will ignore anything after the second predicate. This change
fixes the issue by forwarding the remainin
Fokko opened a new pull request, #66:
URL: https://github.com/apache/iceberg-python/pull/66
I would love to run dependabot daily instead of weekly. Now we're in our own
repository, we'll introduce less noise. This would have helped us to identify
the issue with Pydantic earlier.
--
This
amogh-jahagirdar commented on code in PR #65:
URL: https://github.com/apache/iceberg-python/pull/65#discussion_r1358113965
##
pyiceberg/expressions/parser.py:
##
@@ -233,10 +233,14 @@ def handle_not(result: ParseResults) -> Not:
def handle_and(result: ParseResults) -> And:
Fokko commented on PR #65:
URL: https://github.com/apache/iceberg-python/pull/65#issuecomment-1761329387
This is a serious one, thanks for reporting @puchengy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
Fokko commented on code in PR #65:
URL: https://github.com/apache/iceberg-python/pull/65#discussion_r1358122959
##
pyiceberg/expressions/parser.py:
##
@@ -233,10 +233,14 @@ def handle_not(result: ParseResults) -> Not:
def handle_and(result: ParseResults) -> And:
+if len
liurenjie1024 commented on code in PR #79:
URL: https://github.com/apache/iceberg-rust/pull/79#discussion_r1358133729
##
crates/iceberg/src/spec/values.rs:
##
@@ -966,6 +978,547 @@ mod timestamptz {
}
}
+mod serde {
Review Comment:
I'm ok with this approach, cc @JanK
amogh-jahagirdar commented on code in PR #65:
URL: https://github.com/apache/iceberg-python/pull/65#discussion_r1358137792
##
pyiceberg/expressions/parser.py:
##
@@ -233,10 +233,14 @@ def handle_not(result: ParseResults) -> Not:
def handle_and(result: ParseResults) -> And:
liurenjie1024 commented on code in PR #78:
URL: https://github.com/apache/iceberg-rust/pull/78#discussion_r1357791341
##
crates/iceberg/Cargo.toml:
##
@@ -41,20 +41,24 @@ either = "1"
futures = "0.3"
itertools = "0.11"
lazy_static = "1"
+log = "^0.4"
murmur3 = "0.5.2"
once_
amogh-jahagirdar commented on code in PR #65:
URL: https://github.com/apache/iceberg-python/pull/65#discussion_r1358138359
##
pyiceberg/expressions/parser.py:
##
@@ -233,10 +233,14 @@ def handle_not(result: ParseResults) -> Not:
def handle_and(result: ParseResults) -> And:
amogh-jahagirdar commented on PR #65:
URL: https://github.com/apache/iceberg-python/pull/65#issuecomment-1761366348
Yes thanks @puchengy for reporting this, please also take a look a this fix
when you get a chance!
--
This is an automated message from the Apache Git Service.
To respond to
Xuanwo commented on issue #67:
URL: https://github.com/apache/iceberg-rust/issues/67#issuecomment-1761422712
I'm going to make this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
amogh-jahagirdar merged PR #8814:
URL: https://github.com/apache/iceberg/pull/8814
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ic
nastra commented on code in PR #7913:
URL: https://github.com/apache/iceberg/pull/7913#discussion_r1358250961
##
core/src/main/java/org/apache/iceberg/rest/CatalogHandlers.java:
##
@@ -374,4 +385,107 @@ static TableMetadata commit(TableOperations ops,
UpdateTableRequest request
jbonofre opened a new pull request, #8826:
URL: https://github.com/apache/iceberg/pull/8826
Close #8825
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-m
jbonofre commented on PR #8238:
URL: https://github.com/apache/iceberg/pull/8238#issuecomment-1761561894
I propose to close this PR in favor of #8830
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
jbonofre opened a new pull request, #8828:
URL: https://github.com/apache/iceberg/pull/8828
Close #8827
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-m
jbonofre opened a new issue, #8825:
URL: https://github.com/apache/iceberg/issues/8825
### Feature Request / Improvement
Reproducible builds is a development practice that create an
independently-verifiable path from source to binary code.
A build is reproducible if given the same
nastra commented on code in PR #8808:
URL: https://github.com/apache/iceberg/pull/8808#discussion_r1358326874
##
flink/v1.15/flink/src/test/java/org/apache/iceberg/flink/data/TestFlinkParquetReader.java:
##
@@ -90,17 +92,72 @@ public void testTwoLevelList() throws IOException {
nastra commented on code in PR #8808:
URL: https://github.com/apache/iceberg/pull/8808#discussion_r1358327260
##
flink/v1.15/flink/src/test/java/org/apache/iceberg/flink/data/TestFlinkParquetReader.java:
##
@@ -90,17 +92,72 @@ public void testTwoLevelList() throws IOException {
nastra commented on code in PR #8808:
URL: https://github.com/apache/iceberg/pull/8808#discussion_r1358331014
##
flink/v1.15/flink/src/test/java/org/apache/iceberg/flink/data/TestFlinkParquetReader.java:
##
@@ -90,17 +92,72 @@ public void testTwoLevelList() throws IOException {
jbonofre commented on PR #8788:
URL: https://github.com/apache/iceberg/pull/8788#issuecomment-1761560686
I propose to close this PR in favor of #8830
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
ajantha-bhat closed pull request #8238: Build: Bump jetty from 9.4.43.v20210629
to 11.0.15
URL: https://github.com/apache/iceberg/pull/8238
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
ajantha-bhat commented on PR #8238:
URL: https://github.com/apache/iceberg/pull/8238#issuecomment-1761663164
> I propose to close this PR in favor of
https://github.com/apache/iceberg/pull/8830
Agree. Thanks for raising the PR to support the last JDK8 version.
--
This is an automa
dependabot[bot] commented on PR #8238:
URL: https://github.com/apache/iceberg/pull/8238#issuecomment-1761663265
OK, I won't notify you again about this release, but will get in touch when
a new version is available. You can also ignore all major, minor, or patch
releases for a dependency by
dependabot[bot] commented on PR #8788:
URL: https://github.com/apache/iceberg/pull/8788#issuecomment-1761667373
OK, I won't notify you again about this release, but will get in touch when
a new version is available. You can also ignore all major, minor, or patch
releases for a dependency by
ajantha-bhat commented on PR #8788:
URL: https://github.com/apache/iceberg/pull/8788#issuecomment-1761667236
I propose to close this PR in favor of
https://github.com/apache/iceberg/pull/8830
Agree. Thanks for raising the PR to support the last JDK8 version.
--
This is an automated
ajantha-bhat closed pull request #8788: Build: Bump jetty from 9.4.43.v20210629
to 11.0.17
URL: https://github.com/apache/iceberg/pull/8788
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
ajantha-bhat closed pull request #8811: Build: Bump
org.springframework:spring-web from 5.3.9 to 6.0.13
URL: https://github.com/apache/iceberg/pull/8811
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
dependabot[bot] commented on PR #8811:
URL: https://github.com/apache/iceberg/pull/8811#issuecomment-1761669389
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor version, let
ajantha-bhat commented on PR #8811:
URL: https://github.com/apache/iceberg/pull/8811#issuecomment-1761669307
Closing in the favour of https://github.com/apache/iceberg/pull/8828
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
huaxingao commented on PR #6252:
URL: https://github.com/apache/iceberg/pull/6252#issuecomment-1761680652
@atifiu File statistics are not accurate and can't be used any more if you
use filters.
For example, you have table (col int), the max of col is 100, and the min is
0, so the sta
atifiu commented on PR #6252:
URL: https://github.com/apache/iceberg/pull/6252#issuecomment-1761688659
@huaxingao so you meant to say that with filters whether on partitioned or
non partitioned column(s), aggregate pushdown will not work ?
--
This is an automated message from the Apache G
puchengy commented on PR #65:
URL: https://github.com/apache/iceberg-python/pull/65#issuecomment-1761695595
@amogh-jahagirdar The test result LGTM. However, I am not familiar with the
implementation, please feel free to go ahead and merge.
--
This is an automated message from the Apache G
nastra merged PR #8828:
URL: https://github.com/apache/iceberg/pull/8828
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac
nastra closed issue #8829: Upgrade to Jetty 9.4.53.v20231009
URL: https://github.com/apache/iceberg/issues/8829
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
nastra merged PR #8830:
URL: https://github.com/apache/iceberg/pull/8830
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac
nastra closed issue #8827: Upgrade to spring-web 5.3.30
URL: https://github.com/apache/iceberg/issues/8827
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mai
huaxingao commented on PR #6252:
URL: https://github.com/apache/iceberg/pull/6252#issuecomment-1761909655
If filters are on partitioned columns, aggregate pushdown should work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
atifiu commented on PR #6252:
URL: https://github.com/apache/iceberg/pull/6252#issuecomment-1761916077
It's not working. Either with between, > or <.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
amogh-jahagirdar merged PR #8813:
URL: https://github.com/apache/iceberg/pull/8813
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ic
nastra commented on code in PR #7913:
URL: https://github.com/apache/iceberg/pull/7913#discussion_r1358620356
##
core/src/main/java/org/apache/iceberg/rest/CatalogHandlers.java:
##
@@ -374,4 +385,107 @@ static TableMetadata commit(TableOperations ops,
UpdateTableRequest request
rdblue commented on code in PR #65:
URL: https://github.com/apache/iceberg-python/pull/65#discussion_r1358624936
##
pyiceberg/expressions/parser.py:
##
@@ -233,11 +233,11 @@ def handle_not(result: ParseResults) -> Not:
def handle_and(result: ParseResults) -> And:
-retur
rdblue commented on code in PR #65:
URL: https://github.com/apache/iceberg-python/pull/65#discussion_r1358624936
##
pyiceberg/expressions/parser.py:
##
@@ -233,11 +233,11 @@ def handle_not(result: ParseResults) -> Not:
def handle_and(result: ParseResults) -> And:
-retur
rdblue commented on PR #65:
URL: https://github.com/apache/iceberg-python/pull/65#issuecomment-1761946877
Thanks for jumping on the fix, @amogh-jahagirdar!
@Fokko, should we release 0.5.1 with this patch?
--
This is an automated message from the Apache Git Service.
To respond to the
Fokko commented on PR #65:
URL: https://github.com/apache/iceberg-python/pull/65#issuecomment-1761997037
> @Fokko, should we release 0.5.1 with this patch?
Yes, I think that's a good idea
--
This is an automated message from the Apache Git Service.
To respond to the message, please
Fokko merged PR #65:
URL: https://github.com/apache/iceberg-python/pull/65
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap
Fokko closed issue #64: [BUG] string row filter ignore 2nd (and onwards) And
URL: https://github.com/apache/iceberg-python/issues/64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
Fokko commented on PR #63:
URL: https://github.com/apache/iceberg-python/pull/63#issuecomment-1762014542
@puchengy can you fix the CI? We need to make this part of 0.5.1 since the
`spec_id `was there before (as you pointed out on Slack :)
--
This is an automated message from the Apache Gi
Fokko closed issue #14: AvroWriter Issue: Incorrect iceberg_to_avro Schema
Conversion for Decimal, Fixed, and UUID
URL: https://github.com/apache/iceberg-python/issues/14
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
Fokko merged PR #53:
URL: https://github.com/apache/iceberg-python/pull/53
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap
puchengy commented on PR #63:
URL: https://github.com/apache/iceberg-python/pull/63#issuecomment-1762024206
@Fokko Will do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
Fokko commented on PR #63:
URL: https://github.com/apache/iceberg-python/pull/63#issuecomment-1762031697
@puchengy
`make install && make lint` should fix it. It also looks like the
integration test is failing because FastAvro is missing the `spec_id` (and this
is correct because it
puchengy commented on PR #63:
URL: https://github.com/apache/iceberg-python/pull/63#issuecomment-1762044854
@Fokko thanks I will address that today or tomorrow. If this becomes a
blocker of the release, feel free to take it over.
--
This is an automated message from the Apache Git Service
Fokko commented on PR #63:
URL: https://github.com/apache/iceberg-python/pull/63#issuecomment-1762064930
@puchengy let me give it a try
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
Fokko commented on PR #63:
URL: https://github.com/apache/iceberg-python/pull/63#issuecomment-1762074280
@puchengy I think this fixes it:
https://github.com/puchengy/iceberg-python/pull/1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
huaxingao commented on PR #6252:
URL: https://github.com/apache/iceberg/pull/6252#issuecomment-1762149585
@atifiu I suspect somehow your partition filter isn't completely pushed
down. In this [PR](https://github.com/apache/iceberg/pull/6524), we will
discard filters that can be completely e
Fokko opened a new pull request, #67:
URL: https://github.com/apache/iceberg-python/pull/67
Check if the dependencies are okay
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
Fokko merged PR #45:
URL: https://github.com/apache/iceberg-python/pull/45
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap
Fokko opened a new pull request, #68:
URL: https://github.com/apache/iceberg-python/pull/68
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-m
Fokko opened a new pull request, #69:
URL: https://github.com/apache/iceberg-python/pull/69
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-m
Fokko merged PR #62:
URL: https://github.com/apache/iceberg-python/pull/62
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap
Fokko opened a new pull request, #70:
URL: https://github.com/apache/iceberg-python/pull/70
Should be `FIXED_LEN_BYTE_ARRAY`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
barronw commented on code in PR #76:
URL: https://github.com/apache/iceberg-rust/pull/76#discussion_r1358866184
##
crates/iceberg/src/spec/manifest_list.rs:
##
@@ -940,4 +1017,104 @@ mod test {
r#"[{"manifest_path":"s3a://icebergdata/demo/s1/t1/metadata/05ffe08b-81
barronw commented on code in PR #76:
URL: https://github.com/apache/iceberg-rust/pull/76#discussion_r1358866633
##
crates/iceberg/src/spec/manifest_list.rs:
##
@@ -69,6 +73,25 @@ impl ManifestList {
&self.entries
}
+/// Get the v1 schema of the manifest list
1 - 100 of 111 matches
Mail list logo
