nastra commented on code in PR #8808:
URL: https://github.com/apache/iceberg/pull/8808#discussion_r1358102450
##########
flink/v1.15/flink/src/test/java/org/apache/iceberg/flink/data/TestFlinkParquetReader.java:
##########
@@ -98,6 +100,62 @@ public void testTwoLevelList() throws IOException {
}
}
+ @Test
+ public void testReadBinaryFieldAsString() throws IOException {
+ Schema schemaForWriteBinary = new Schema(optional(1, "strbytes",
Types.BinaryType.get()));
+ org.apache.avro.Schema avroSchema =
AvroSchemaUtil.convert(schemaForWriteBinary.asStruct());
+
+ File testFile = temp.newFile();
+ Assert.assertTrue(testFile.delete());
Review Comment:
please use AssertJ-style assertions for newly added tests
(https://iceberg.apache.org/contribute/#assertj). This makes it easier to
migrate from JUnit4 to JUnit5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
