nastra commented on code in PR #8678:
URL: https://github.com/apache/iceberg/pull/8678#discussion_r1357853053
##########
core/src/main/java/org/apache/iceberg/view/BaseMetastoreViewCatalog.java:
##########
@@ -161,7 +162,7 @@ private View create(ViewOperations ops) {
.defaultNamespace(defaultNamespace)
.defaultCatalog(defaultCatalog)
.timestampMillis(System.currentTimeMillis())
- .putSummary("operation", "create")
+ .putAllSummary(EnvironmentContext.get())
Review Comment:
in https://iceberg.apache.org/view-spec/#summary we mention that the summary
might contain the engine name/version, so I figured it makes sense to add this
info from `EnvironmentContext` here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
