nastra commented on code in PR #8678:
URL: https://github.com/apache/iceberg/pull/8678#discussion_r1357855073


##########
core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java:
##########
@@ -99,7 +100,7 @@ public void basicCreateView() {
                 .timestampMillis(view.currentVersion().timestampMillis())
                 .versionId(1)
                 .schemaId(0)
-                .putSummary("operation", "create")
+                .summary(view.currentVersion().summary())

Review Comment:
   we could also use `EnvironmentContext.get()` here for comparison, but I'm 
not sure if this might later cause test issues when view support is added for 
other engines



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to