Fokko commented on code in PR #8819:
URL: https://github.com/apache/iceberg/pull/8819#discussion_r1357986438
##########
aws/src/integration/java/org/apache/iceberg/aws/glue/TestGlueCatalogNamespace.java:
##########
@@ -105,7 +105,7 @@ public void testNamespaceExists() {
public void testListNamespace() {
String namespace = createNamespace();
List<Namespace> namespaceList = glueCatalog.listNamespaces();
- Assert.assertTrue(namespaceList.size() > 0);
+ Assert.assertFalse(namespaceList.isEmpty());
Review Comment:
Nice, much easier to read 👍
##########
aws/src/integration/java/org/apache/iceberg/aws/glue/TestGlueCatalogNamespace.java:
##########
@@ -105,7 +105,7 @@ public void testNamespaceExists() {
public void testListNamespace() {
String namespace = createNamespace();
List<Namespace> namespaceList = glueCatalog.listNamespaces();
- Assert.assertTrue(namespaceList.size() > 0);
+ Assert.assertFalse(namespaceList.isEmpty());
Review Comment:
Nice, much easier to read 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
