amogh-jahagirdar commented on issue #8824: URL: https://github.com/apache/iceberg/issues/8824#issuecomment-1761134284
Yeah, I'd probably start with making this https://github.com/apache/iceberg/blob/main/spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRemoveOrphanFilesAction.java#L273 a `ConcurrentHashMap.newKeySet();`. Even though the implementation inserts unique elements (file paths), there are no thread safety guarantees on normal hash sets. I think it's possible there could be some weird corruptions of internal state on the underlying table/buckets in the set which lead to missing elements. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
