Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-05-22 Thread via GitHub
stevenzwu commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2103603849 ## core/src/main/java/org/apache/iceberg/io/WriteBuilder.java: ## @@ -0,0 +1,120 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more c

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-05-21 Thread via GitHub
stevenzwu commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2098593221 ## data/src/main/java/org/apache/iceberg/data/PositionDeleteWriteBuilder.java: ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-05-21 Thread via GitHub
pvary commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2100279569 ## data/src/main/java/org/apache/iceberg/data/PositionDeleteWriteBuilder.java: ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-05-21 Thread via GitHub
pvary commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2100272067 ## core/src/main/java/org/apache/iceberg/io/WriteBuilder.java: ## @@ -0,0 +1,120 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contr

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-05-21 Thread via GitHub
pvary commented on PR #12774: URL: https://github.com/apache/iceberg/pull/12774#issuecomment-2897962911 > @huaxingao, @pvary Could you take a look from a comet prospective? I know you have some custom code that would be using this as well Originally I thought that the `comet` could be

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-05-21 Thread via GitHub
pvary commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2100282469 ## data/src/main/java/org/apache/iceberg/data/FileAccessFactoryRegistry.java: ## @@ -0,0 +1,269 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-05-21 Thread via GitHub
pvary commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2100280432 ## core/src/main/java/org/apache/iceberg/io/WriteBuilder.java: ## @@ -0,0 +1,120 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contr

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-05-21 Thread via GitHub
pvary commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2100278943 ## core/src/main/java/org/apache/iceberg/io/WriteBuilder.java: ## @@ -0,0 +1,120 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contr

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-05-21 Thread via GitHub
pvary commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2100237439 ## core/src/main/java/org/apache/iceberg/io/WriteBuilder.java: ## @@ -0,0 +1,120 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contr

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-05-21 Thread via GitHub
pvary commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2100276172 ## core/src/main/java/org/apache/iceberg/io/WriteBuilder.java: ## @@ -0,0 +1,120 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contr

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-05-21 Thread via GitHub
pvary commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2100237439 ## core/src/main/java/org/apache/iceberg/io/WriteBuilder.java: ## @@ -0,0 +1,120 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contr

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-05-21 Thread via GitHub
pvary commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2099792831 ## core/src/main/java/org/apache/iceberg/io/WriteBuilder.java: ## @@ -0,0 +1,120 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contr

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-05-21 Thread via GitHub
pvary commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2099787997 ## core/src/main/java/org/apache/iceberg/io/WriteBuilder.java: ## @@ -0,0 +1,120 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contr

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-05-21 Thread via GitHub
pvary commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2099787997 ## core/src/main/java/org/apache/iceberg/io/WriteBuilder.java: ## @@ -0,0 +1,120 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contr

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-05-21 Thread via GitHub
pvary commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2099755461 ## data/src/main/java/org/apache/iceberg/data/ContentFileWriteBuilderImpl.java: ## @@ -0,0 +1,251 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-05-21 Thread via GitHub
pvary commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2099765989 ## data/src/main/java/org/apache/iceberg/data/ContentFileWriteBuilderImpl.java: ## @@ -0,0 +1,251 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-05-21 Thread via GitHub
pvary commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2099762112 ## data/src/main/java/org/apache/iceberg/data/ContentFileWriteBuilder.java: ## @@ -0,0 +1,126 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-05-21 Thread via GitHub
pvary commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2099753128 ## data/src/main/java/org/apache/iceberg/data/PositionDeleteWriteBuilder.java: ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-05-21 Thread via GitHub
pvary commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2099750595 ## core/src/main/java/org/apache/iceberg/io/ReadBuilder.java: ## @@ -0,0 +1,131 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contri

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-05-20 Thread via GitHub
RussellSpitzer commented on PR #12774: URL: https://github.com/apache/iceberg/pull/12774#issuecomment-2895768606 @huaxingao, @pvary Could you take a look from a comet prospective? I know you have some custom code that would be using this as well -- This is an automated message from the Ap

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-05-20 Thread via GitHub
RussellSpitzer commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2098824679 ## data/src/main/java/org/apache/iceberg/data/FileAccessFactoryRegistry.java: ## @@ -0,0 +1,269 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-05-20 Thread via GitHub
RussellSpitzer commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2098728163 ## core/src/main/java/org/apache/iceberg/io/WriteBuilder.java: ## @@ -0,0 +1,120 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or m

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-05-20 Thread via GitHub
RussellSpitzer commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2098726421 ## core/src/main/java/org/apache/iceberg/io/WriteBuilder.java: ## @@ -0,0 +1,120 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or m

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-05-20 Thread via GitHub
RussellSpitzer commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2098711363 ## core/src/main/java/org/apache/iceberg/io/WriteBuilder.java: ## @@ -0,0 +1,120 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or m

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-05-20 Thread via GitHub
stevenzwu commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2098442003 ## core/src/main/java/org/apache/iceberg/io/WriteBuilder.java: ## @@ -0,0 +1,120 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more c

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-05-20 Thread via GitHub
stevenzwu commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2098385095 ## core/src/main/java/org/apache/iceberg/io/AppenderBuilder.java: ## @@ -0,0 +1,109 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mor

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-05-20 Thread via GitHub
pvary commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2097739913 ## core/src/main/java/org/apache/iceberg/io/AppenderBuilder.java: ## @@ -0,0 +1,109 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more co

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-05-20 Thread via GitHub
pvary commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2097607928 ## core/src/main/java/org/apache/iceberg/io/ObjectModel.java: ## @@ -0,0 +1,106 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contri

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-05-20 Thread via GitHub
pvary commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2097742734 ## core/src/main/java/org/apache/iceberg/io/ObjectModel.java: ## @@ -0,0 +1,106 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contri

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-05-20 Thread via GitHub
pvary commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2097304773 ## core/src/main/java/org/apache/iceberg/io/AppenderBuilder.java: ## @@ -0,0 +1,109 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more co

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-05-19 Thread via GitHub
stevenzwu commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2096253249 ## core/src/main/java/org/apache/iceberg/io/ObjectModel.java: ## @@ -0,0 +1,106 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more co

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-05-19 Thread via GitHub
stevenzwu commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2096242698 ## core/src/main/java/org/apache/iceberg/io/ObjectModel.java: ## @@ -0,0 +1,106 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more co

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-05-19 Thread via GitHub
stevenzwu commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2096253249 ## core/src/main/java/org/apache/iceberg/io/ObjectModel.java: ## @@ -0,0 +1,106 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more co

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-05-19 Thread via GitHub
stevenzwu commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2096242698 ## core/src/main/java/org/apache/iceberg/io/ObjectModel.java: ## @@ -0,0 +1,106 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more co

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-05-19 Thread via GitHub
stevenzwu commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2096231250 ## core/src/main/java/org/apache/iceberg/io/ObjectModel.java: ## @@ -0,0 +1,106 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more co

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-05-19 Thread via GitHub
stevenzwu commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2096231250 ## core/src/main/java/org/apache/iceberg/io/ObjectModel.java: ## @@ -0,0 +1,106 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more co

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-05-19 Thread via GitHub
stevenzwu commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2096136844 ## core/src/main/java/org/apache/iceberg/io/AppenderBuilder.java: ## @@ -0,0 +1,109 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mor

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-05-19 Thread via GitHub
pvary commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2095199785 ## core/src/main/java/org/apache/iceberg/io/ObjectModel.java: ## @@ -0,0 +1,106 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contri

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-05-19 Thread via GitHub
pvary commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2095261258 ## core/src/main/java/org/apache/iceberg/io/ObjectModel.java: ## @@ -0,0 +1,106 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contri

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-05-19 Thread via GitHub
pvary commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2095229232 ## data/src/main/java/org/apache/iceberg/data/ObjectModelRegistry.java: ## @@ -0,0 +1,224 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or m

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-05-19 Thread via GitHub
pvary commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2095481654 ## core/src/main/java/org/apache/iceberg/io/AppenderBuilder.java: ## @@ -0,0 +1,109 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more co

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-05-19 Thread via GitHub
pvary commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2095462749 ## core/src/main/java/org/apache/iceberg/io/ObjectModel.java: ## @@ -0,0 +1,106 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contri

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-05-19 Thread via GitHub
pvary commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2095464916 ## data/src/main/java/org/apache/iceberg/data/FileWriteBuilderBase.java: ## @@ -0,0 +1,54 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or m

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-05-19 Thread via GitHub
pvary commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2095464534 ## core/src/main/java/org/apache/iceberg/io/ReadBuilder.java: ## @@ -0,0 +1,123 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contri

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-05-19 Thread via GitHub
pvary commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2095463240 ## core/src/main/java/org/apache/iceberg/io/AppenderBuilder.java: ## @@ -0,0 +1,109 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more co

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-05-19 Thread via GitHub
pvary commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2095395202 ## core/src/main/java/org/apache/iceberg/io/ObjectModel.java: ## @@ -0,0 +1,106 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contri

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-05-19 Thread via GitHub
pvary commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2095261258 ## core/src/main/java/org/apache/iceberg/io/ObjectModel.java: ## @@ -0,0 +1,106 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contri

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-05-19 Thread via GitHub
pvary commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2095324612 ## core/src/main/java/org/apache/iceberg/io/ReadBuilder.java: ## @@ -0,0 +1,123 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contri

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-05-19 Thread via GitHub
pvary commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2095316334 ## data/src/main/java/org/apache/iceberg/data/FileWriteBuilderBase.java: ## @@ -0,0 +1,54 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or m

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-05-19 Thread via GitHub
pvary commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2095300900 ## core/src/main/java/org/apache/iceberg/io/ReadBuilder.java: ## @@ -0,0 +1,123 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contri

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-05-19 Thread via GitHub
liurenjie1024 commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2095242462 ## core/src/main/java/org/apache/iceberg/io/ObjectModel.java: ## @@ -0,0 +1,106 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mor

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-05-16 Thread via GitHub
stevenzwu commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2093779618 ## data/src/main/java/org/apache/iceberg/data/FileWriteBuilderBase.java: ## @@ -0,0 +1,54 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-05-16 Thread via GitHub
stevenzwu commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2093626096 ## core/src/main/java/org/apache/iceberg/io/ObjectModel.java: ## @@ -0,0 +1,106 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more co

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-05-16 Thread via GitHub
stevenzwu commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2093651265 ## core/src/main/java/org/apache/iceberg/io/AppenderBuilder.java: ## @@ -0,0 +1,109 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mor

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-05-16 Thread via GitHub
stevenzwu commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2093626096 ## core/src/main/java/org/apache/iceberg/io/ObjectModel.java: ## @@ -0,0 +1,106 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more co

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-05-08 Thread via GitHub
pvary commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2079085605 ## core/src/main/java/org/apache/iceberg/io/AppenderBuilder.java: ## @@ -0,0 +1,109 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more co

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-05-08 Thread via GitHub
pvary commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2079076379 ## core/src/main/java/org/apache/iceberg/io/AppenderBuilder.java: ## @@ -0,0 +1,109 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more co

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-05-07 Thread via GitHub
stevenzwu commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2078064222 ## core/src/main/java/org/apache/iceberg/io/AppenderBuilder.java: ## @@ -0,0 +1,109 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mor

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-05-07 Thread via GitHub
pvary commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2077373497 ## data/src/main/java/org/apache/iceberg/data/ObjectModelRegistry.java: ## @@ -36,10 +36,10 @@ /** * Registry which provides the available {@link ReadBuilder}s and

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-05-07 Thread via GitHub
pvary commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2077374214 ## data/src/main/java/org/apache/iceberg/data/ObjectModelRegistry.java: ## @@ -49,9 +49,13 @@ public final class ObjectModelRegistry { private static final Logger L

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-05-07 Thread via GitHub
liurenjie1024 commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2077289136 ## data/src/main/java/org/apache/iceberg/data/ObjectModelRegistry.java: ## @@ -36,10 +36,10 @@ /** * Registry which provides the available {@link ReadBuild

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-05-06 Thread via GitHub
pvary commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2075842898 ## data/src/main/java/org/apache/iceberg/data/AppenderBuilder.java: ## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more c

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-05-06 Thread via GitHub
jbonofre commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2075469793 ## data/src/main/java/org/apache/iceberg/data/AppenderBuilder.java: ## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mor

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-05-06 Thread via GitHub
liurenjie1024 commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2075163985 ## data/src/main/java/org/apache/iceberg/data/AppenderBuilder.java: ## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * o

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-05-05 Thread via GitHub
pvary commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2073415112 ## data/src/main/java/org/apache/iceberg/data/AppenderBuilder.java: ## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more c

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-04-30 Thread via GitHub
pvary commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2068340171 ## data/src/main/java/org/apache/iceberg/data/AppenderBuilder.java: ## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more c

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-04-30 Thread via GitHub
pvary commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2068307219 ## data/src/main/java/org/apache/iceberg/data/ObjectModelRegistry.java: ## @@ -0,0 +1,224 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or m

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-04-29 Thread via GitHub
liurenjie1024 commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2067958054 ## data/src/main/java/org/apache/iceberg/data/PositionDeleteWriterBuilder.java: ## @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-04-29 Thread via GitHub
pvary commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2066040201 ## data/src/main/java/org/apache/iceberg/data/AppenderBuilder.java: ## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more c

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-04-29 Thread via GitHub
pvary commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2066040536 ## data/src/main/java/org/apache/iceberg/data/ObjectModelRegistry.java: ## @@ -0,0 +1,224 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or m

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-04-29 Thread via GitHub
pvary commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2066023603 ## data/src/main/java/org/apache/iceberg/data/ObjectModelRegistry.java: ## @@ -0,0 +1,224 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or m

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-04-29 Thread via GitHub
pvary commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2066022181 ## data/src/main/java/org/apache/iceberg/data/ObjectModelRegistry.java: ## @@ -0,0 +1,224 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or m

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-04-29 Thread via GitHub
pvary commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2066013312 ## core/src/main/java/org/apache/iceberg/io/AppenderBuilder.java: ## @@ -0,0 +1,139 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more co

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-04-29 Thread via GitHub
pvary commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2066004093 ## data/src/main/java/org/apache/iceberg/data/PositionDeleteWriterBuilder.java: ## @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-04-29 Thread via GitHub
pvary commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2065986466 ## data/src/main/java/org/apache/iceberg/data/ObjectModelRegistry.java: ## @@ -0,0 +1,224 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or m

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-04-23 Thread via GitHub
wgtmac commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2057631093 ## data/src/main/java/org/apache/iceberg/data/AppenderBuilder.java: ## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-04-21 Thread via GitHub
liurenjie1024 commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2045976962 ## data/src/main/java/org/apache/iceberg/data/ObjectModelRegistry.java: ## @@ -0,0 +1,224 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one