liurenjie1024 commented on code in PR #12774:
URL: https://github.com/apache/iceberg/pull/12774#discussion_r2077289136
##########
data/src/main/java/org/apache/iceberg/data/ObjectModelRegistry.java:
##########
@@ -36,10 +36,10 @@
/**
* Registry which provides the available {@link ReadBuilder}s and writer
builders ({@link
- * org.apache.iceberg.data.AppenderBuilder}, {@link DataWriterBuilder}, {@link
- * EqualityDeleteWriterBuilder}, {@link PositionDeleteWriterBuilder}). Based
on the `file format`
- * and the requested `object model name` the registry returns the correct
reader and writer
- * builders. These builders could be used to generate the readers and writers.
+ * AppenderBuilder}, {@link DataWriterBuilder}, {@link
EqualityDeleteWriterBuilder}, {@link
Review Comment:
```suggestion
{@link DataWriterBuilder}, {@link EqualityDeleteWriterBuilder}, {@link
```
##########
data/src/main/java/org/apache/iceberg/data/ObjectModelRegistry.java:
##########
@@ -49,9 +49,13 @@
public final class ObjectModelRegistry {
private static final Logger LOG =
LoggerFactory.getLogger(ObjectModelRegistry.class);
// The list of classes which are used for registering the reader and writer
builders
- private static final List<String> CLASSES_TO_REGISTER = ImmutableList.of();
+ private static final List<String> CLASSES_TO_REGISTER =
+ ImmutableList.of(
+ "org.apache.iceberg.arrow.vectorized.ArrowReader",
+ "org.apache.iceberg.flink.data.FlinkObjectModels",
+ "org.apache.iceberg.spark.source.SparkObjectModels");
Review Comment:
I would prefer to add them one by one when we implement each model.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
