pvary commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2100279569
########## data/src/main/java/org/apache/iceberg/data/PositionDeleteWriteBuilder.java: ########## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.data; + +import java.io.IOException; +import org.apache.iceberg.DeleteFile; +import org.apache.iceberg.Schema; +import org.apache.iceberg.deletes.PositionDelete; +import org.apache.iceberg.deletes.PositionDeleteWriter; + +/** + * A specialized builder for creating position-based delete file writers. + * + * <p>This builder extends the generic {@link ContentFileWriteBuilder} interface with functionality + * specific to creating {@link PositionDeleteWriter} instances. + * + * <p>The builder provides methods to configure the schema for the row data that might be included + * with the position deletes through {@link #rowSchema(Schema)}, enabling optional preservation of + * deleted record content. + * + * @param <B> the concrete builder type for method chaining + * @param <E> engine-specific schema type required by the writer for data conversion + */ +public interface PositionDeleteWriteBuilder<B extends PositionDeleteWriteBuilder<B, E>, E> + extends ContentFileWriteBuilder<B, E> { + /** Sets the row schema for the delete writers. */ + B rowSchema(Schema newSchema); Review Comment: Also moved/rewritten the javadoc -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
