pvary commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2079076379
########## core/src/main/java/org/apache/iceberg/io/AppenderBuilder.java: ########## @@ -0,0 +1,109 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.io; + +import java.io.IOException; +import java.nio.ByteBuffer; +import java.util.Map; +import org.apache.iceberg.MetricsConfig; +import org.apache.iceberg.Schema; + +/** + * Interface which is implemented by the data file format implementations. The {@link ObjectModel} + * provides the {@link AppenderBuilder} for the given parameters: + * + * <ul> + * <li>file format + * <li>engine specific object model + * <li>{@link ObjectModel.WriteMode} + * </ul> + * + * The {@link AppenderBuilder} is used to write data to the target files. + * + * @param <B> type returned by builder API to allow chained calls + * @param <E> the engine specific schema of the input data + */ +public interface AppenderBuilder<B extends AppenderBuilder<B, E>, E> { Review Comment: As an end result, we need to provide 4 interfaces from the ObjectModel: - Appender - generates a `FileAppender` which just writes the data to an output file - DataWriter - generates a `DataWriter` which generates DataFiles - PositionDeleteWriter - generates a `PositionDeleteWriter` which generates DeleteFile - EqualityDeleteWriter - generates a `EqualityDeleteWriter` which generates DeleteFile The PR doesn't touch the results (`FileAppender`, `DataWriter`, `PositionDeleteWriter`, `EqualityDeleteWriter`). I think it is better to keep these names so it is easier to understand what will be the result -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
