pvary commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2066004093
########## data/src/main/java/org/apache/iceberg/data/PositionDeleteWriterBuilder.java: ########## @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.data; + +import java.io.IOException; +import org.apache.iceberg.DeleteFile; +import org.apache.iceberg.Schema; +import org.apache.iceberg.deletes.PositionDeleteWriter; + +/** + * Builder for generating an {@link PositionDeleteWriter}. + * + * @param <B> type of the builder + * @param <E> engine specific schema of the input records used for appender initialization + */ +public interface PositionDeleteWriterBuilder<B extends PositionDeleteWriterBuilder<B, E>, E> + extends FileWriterBuilderBase<B, E> { + /** Sets the row schema for the delete writers. */ + B withRowSchema(Schema newSchema); + Review Comment: The deletes are always expected to be sorted. The writer/appender doesn't sort them. There are several abstraction layers above the actual writers which do the sorting, but at this level we always expect sorted input. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
