Re: [PR] Auth Manager API part 6: API enablement [iceberg]

2025-03-12 Thread via GitHub
adutra commented on code in PR #12197: URL: https://github.com/apache/iceberg/pull/12197#discussion_r1990955877 ## aws/src/main/java/org/apache/iceberg/aws/s3/signer/S3V4RestSignerClient.java: ## @@ -200,86 +151,40 @@ private RESTClient httpClient() { return httpClient;

Re: [PR] Auth Manager API part 6: API enablement [iceberg]

2025-03-11 Thread via GitHub
danielcweeks commented on code in PR #12197: URL: https://github.com/apache/iceberg/pull/12197#discussion_r1990291751 ## aws/src/main/java/org/apache/iceberg/aws/s3/signer/S3V4RestSignerClient.java: ## @@ -200,86 +151,40 @@ private RESTClient httpClient() { return httpClien

Re: [PR] Auth Manager API part 6: API enablement [iceberg]

2025-03-11 Thread via GitHub
adutra commented on code in PR #12197: URL: https://github.com/apache/iceberg/pull/12197#discussion_r1990205373 ## aws/src/main/java/org/apache/iceberg/aws/s3/signer/S3V4RestSignerClient.java: ## @@ -200,86 +151,40 @@ private RESTClient httpClient() { return httpClient;

Re: [PR] Auth Manager API part 6: API enablement [iceberg]

2025-03-11 Thread via GitHub
danielcweeks commented on code in PR #12197: URL: https://github.com/apache/iceberg/pull/12197#discussion_r1990185526 ## aws/src/main/java/org/apache/iceberg/aws/s3/signer/S3V4RestSignerClient.java: ## @@ -200,86 +151,40 @@ private RESTClient httpClient() { return httpClien

Re: [PR] Auth Manager API part 6: API enablement [iceberg]

2025-03-10 Thread via GitHub
adutra commented on PR #12197: URL: https://github.com/apache/iceberg/pull/12197#issuecomment-2710091175 @nastra @danielcweeks can I get another review please? 🙏 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Auth Manager API part 6: API enablement [iceberg]

2025-03-06 Thread via GitHub
adutra commented on code in PR #12197: URL: https://github.com/apache/iceberg/pull/12197#discussion_r1983959694 ## aws/src/test/java/org/apache/iceberg/aws/s3/signer/TestS3V4RestSignerClient.java: ## @@ -0,0 +1,130 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

Re: [PR] Auth Manager API part 6: API enablement [iceberg]

2025-03-05 Thread via GitHub
adutra commented on code in PR #12197: URL: https://github.com/apache/iceberg/pull/12197#discussion_r1981429970 ## aws/src/main/java/org/apache/iceberg/aws/s3/signer/S3V4RestSignerClient.java: ## @@ -138,148 +133,42 @@ boolean keepTokenRefreshed() { OAuth2Properties.TOK

Re: [PR] Auth Manager API part 6: API enablement [iceberg]

2025-03-04 Thread via GitHub
danielcweeks commented on code in PR #12197: URL: https://github.com/apache/iceberg/pull/12197#discussion_r1980175050 ## aws/src/main/java/org/apache/iceberg/aws/s3/signer/S3V4RestSignerClient.java: ## @@ -138,148 +133,42 @@ boolean keepTokenRefreshed() { OAuth2Properti

Re: [PR] Auth Manager API part 6: API enablement [iceberg]

2025-03-04 Thread via GitHub
danielcweeks commented on code in PR #12197: URL: https://github.com/apache/iceberg/pull/12197#discussion_r1979920103 ## aws/src/main/java/org/apache/iceberg/aws/s3/signer/S3V4RestSignerClient.java: ## @@ -81,13 +76,13 @@ public abstract class S3V4RestSignerClient private sta

Re: [PR] Auth Manager API part 6: API enablement [iceberg]

2025-03-04 Thread via GitHub
adutra commented on code in PR #12197: URL: https://github.com/apache/iceberg/pull/12197#discussion_r1979951530 ## aws/src/main/java/org/apache/iceberg/aws/s3/signer/S3V4RestSignerClient.java: ## @@ -81,13 +76,13 @@ public abstract class S3V4RestSignerClient private static fi

Re: [PR] Auth Manager API part 6: API enablement [iceberg]

2025-03-04 Thread via GitHub
danielcweeks commented on code in PR #12197: URL: https://github.com/apache/iceberg/pull/12197#discussion_r1979920103 ## aws/src/main/java/org/apache/iceberg/aws/s3/signer/S3V4RestSignerClient.java: ## @@ -81,13 +76,13 @@ public abstract class S3V4RestSignerClient private sta

Re: [PR] Auth Manager API part 6: API enablement [iceberg]

2025-03-04 Thread via GitHub
danielcweeks commented on code in PR #12197: URL: https://github.com/apache/iceberg/pull/12197#discussion_r1979889796 ## aws/src/main/java/org/apache/iceberg/aws/s3/signer/S3V4RestSignerClient.java: ## @@ -138,148 +133,42 @@ boolean keepTokenRefreshed() { OAuth2Properti

Re: [PR] Auth Manager API part 6: API enablement [iceberg]

2025-03-04 Thread via GitHub
nastra commented on code in PR #12197: URL: https://github.com/apache/iceberg/pull/12197#discussion_r1979704662 ## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ## @@ -198,18 +167,33 @@ Map params() { } public RESTSessionCatalog() { -this(config

Re: [PR] Auth Manager API part 6: API enablement [iceberg]

2025-03-04 Thread via GitHub
adutra commented on code in PR #12197: URL: https://github.com/apache/iceberg/pull/12197#discussion_r1978944549 ## aws/src/main/java/org/apache/iceberg/aws/s3/signer/S3V4RestSignerClient.java: ## @@ -138,148 +133,42 @@ boolean keepTokenRefreshed() { OAuth2Properties.TOK

Re: [PR] Auth Manager API part 6: API enablement [iceberg]

2025-03-04 Thread via GitHub
adutra commented on code in PR #12197: URL: https://github.com/apache/iceberg/pull/12197#discussion_r1978927775 ## aws/src/main/java/org/apache/iceberg/aws/s3/signer/S3V4RestSignerClient.java: ## @@ -138,148 +133,42 @@ boolean keepTokenRefreshed() { OAuth2Properties.TOK

Re: [PR] Auth Manager API part 6: API enablement [iceberg]

2025-03-04 Thread via GitHub
adutra commented on code in PR #12197: URL: https://github.com/apache/iceberg/pull/12197#discussion_r1978906243 ## aws/src/main/java/org/apache/iceberg/aws/s3/signer/S3V4RestSignerClient.java: ## @@ -81,13 +76,13 @@ public abstract class S3V4RestSignerClient private static fi

Re: [PR] Auth Manager API part 6: API enablement [iceberg]

2025-03-03 Thread via GitHub
danielcweeks commented on code in PR #12197: URL: https://github.com/apache/iceberg/pull/12197#discussion_r1978340592 ## aws/src/main/java/org/apache/iceberg/aws/s3/signer/S3V4RestSignerClient.java: ## @@ -138,148 +133,42 @@ boolean keepTokenRefreshed() { OAuth2Properti

Re: [PR] Auth Manager API part 6: API enablement [iceberg]

2025-03-03 Thread via GitHub
danielcweeks commented on code in PR #12197: URL: https://github.com/apache/iceberg/pull/12197#discussion_r1978418025 ## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ## @@ -462,12 +375,15 @@ public boolean tableExists(SessionContext context, TableIdentifi

Re: [PR] Auth Manager API part 6: API enablement [iceberg]

2025-03-03 Thread via GitHub
danielcweeks commented on code in PR #12197: URL: https://github.com/apache/iceberg/pull/12197#discussion_r1978418025 ## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ## @@ -462,12 +375,15 @@ public boolean tableExists(SessionContext context, TableIdentifi

Re: [PR] Auth Manager API part 6: API enablement [iceberg]

2025-03-03 Thread via GitHub
danielcweeks commented on code in PR #12197: URL: https://github.com/apache/iceberg/pull/12197#discussion_r1978340592 ## aws/src/main/java/org/apache/iceberg/aws/s3/signer/S3V4RestSignerClient.java: ## @@ -138,148 +133,42 @@ boolean keepTokenRefreshed() { OAuth2Properti

Re: [PR] Auth Manager API part 6: API enablement [iceberg]

2025-03-03 Thread via GitHub
danielcweeks commented on PR #12197: URL: https://github.com/apache/iceberg/pull/12197#issuecomment-2695640318 @adutra A few comments, but I'm also running into issues with the SigV4 signer implementation while testing this. Trying to track down what the behavior difference is. -- This

Re: [PR] Auth Manager API part 6: API enablement [iceberg]

2025-03-03 Thread via GitHub
danielcweeks commented on code in PR #12197: URL: https://github.com/apache/iceberg/pull/12197#discussion_r1978070687 ## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ## @@ -198,18 +167,33 @@ Map params() { } public RESTSessionCatalog() { -this(

Re: [PR] Auth Manager API part 6: API enablement [iceberg]

2025-03-03 Thread via GitHub
danielcweeks commented on code in PR #12197: URL: https://github.com/apache/iceberg/pull/12197#discussion_r1978070687 ## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ## @@ -198,18 +167,33 @@ Map params() { } public RESTSessionCatalog() { -this(

Re: [PR] Auth Manager API part 6: API enablement [iceberg]

2025-03-03 Thread via GitHub
danielcweeks commented on code in PR #12197: URL: https://github.com/apache/iceberg/pull/12197#discussion_r1977989033 ## aws/src/main/java/org/apache/iceberg/aws/s3/signer/S3V4RestSignerClient.java: ## @@ -81,13 +76,13 @@ public abstract class S3V4RestSignerClient private sta

Re: [PR] Auth Manager API part 6: API enablement [iceberg]

2025-02-27 Thread via GitHub
nastra commented on code in PR #12197: URL: https://github.com/apache/iceberg/pull/12197#discussion_r1965346332 ## aws/src/test/java/org/apache/iceberg/aws/s3/signer/TestS3RestSigner.java: ## @@ -86,8 +86,10 @@ public class TestS3RestSigner { MinioUtil.createContainer(CRE

Re: [PR] Auth Manager API part 6: API enablement [iceberg]

2025-02-26 Thread via GitHub
ajantha-bhat commented on PR #12197: URL: https://github.com/apache/iceberg/pull/12197#issuecomment-2687048478 @danielcweeks and @nastra: Can we please start the review on this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Auth Manager API part 6: API enablement [iceberg]

2025-02-24 Thread via GitHub
varpa89 commented on PR #12197: URL: https://github.com/apache/iceberg/pull/12197#issuecomment-2678010968 @adutra thank you for clarification! Actually my question if specific to Trino. Yes, they [use](https://github.com/trinodb/trino/blob/master/plugin/trino-iceberg/src/main/java/io/trin

Re: [PR] Auth Manager API part 6: API enablement [iceberg]

2025-02-24 Thread via GitHub
adutra commented on PR #12197: URL: https://github.com/apache/iceberg/pull/12197#issuecomment-2677874717 > When RestSessionCatalog creates a new session it uses AuthSession.fromAccessToken method and puts it to the cache (1 hour timeout) And the problem is that the token lifetime that we se

Re: [PR] Auth Manager API part 6: API enablement [iceberg]

2025-02-24 Thread via GitHub
varpa89 commented on PR #12197: URL: https://github.com/apache/iceberg/pull/12197#issuecomment-267331 Hello! Could you please clarify the behaviour in the following case: Trino JDBC driver has an option [extraCredentials](https://trino.io/docs/current/client/jdbc.html#:~:text=to%20fal

Re: [PR] Auth Manager API part 6: API enablement [iceberg]

2025-02-12 Thread via GitHub
ajantha-bhat commented on code in PR #12197: URL: https://github.com/apache/iceberg/pull/12197#discussion_r1953293640 ## aws/src/main/java/org/apache/iceberg/aws/RESTSigV4Signer.java: ## @@ -1,157 +0,0 @@ -/* - * Licensed to the Apache Software Foundation (ASF) under one - * or

Re: [PR] Auth Manager API part 6: API enablement [iceberg]

2025-02-12 Thread via GitHub
adutra commented on code in PR #12197: URL: https://github.com/apache/iceberg/pull/12197#discussion_r1953139950 ## aws/src/main/java/org/apache/iceberg/aws/RESTSigV4Signer.java: ## @@ -1,157 +0,0 @@ -/* - * Licensed to the Apache Software Foundation (ASF) under one - * or more c

Re: [PR] Auth Manager API part 6: API enablement [iceberg]

2025-02-12 Thread via GitHub
ajantha-bhat commented on code in PR #12197: URL: https://github.com/apache/iceberg/pull/12197#discussion_r1953089200 ## aws/src/main/java/org/apache/iceberg/aws/RESTSigV4Signer.java: ## @@ -1,157 +0,0 @@ -/* - * Licensed to the Apache Software Foundation (ASF) under one - * or