danielcweeks commented on code in PR #12197:
URL: https://github.com/apache/iceberg/pull/12197#discussion_r1977989033
##########
aws/src/main/java/org/apache/iceberg/aws/s3/signer/S3V4RestSignerClient.java:
##########
@@ -81,13 +76,13 @@ public abstract class S3V4RestSignerClient
private static final String SCOPE = "sign";
@SuppressWarnings("immutables:incompat")
- private static volatile ScheduledExecutorService tokenRefreshExecutor;
+ private volatile AuthManager authManager;
@SuppressWarnings("immutables:incompat")
- private static volatile RESTClient httpClient;
+ private volatile AuthSession authSession;
@SuppressWarnings("immutables:incompat")
- private static volatile Cache<String, AuthSession> authSessionCache;
+ private volatile RESTClient httpClient;
Review Comment:
I'm a little concerned that this is going to be an issue. It looks like
we're making a separate `AuthMangaer`, `AuthSession`, and `RESTClient` for each
signer instance. I feel like we could reuse at least the http client by
leaving it static (that potentially consumes the most resources).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
