danielcweeks commented on code in PR #12197:
URL: https://github.com/apache/iceberg/pull/12197#discussion_r1979920103
##########
aws/src/main/java/org/apache/iceberg/aws/s3/signer/S3V4RestSignerClient.java:
##########
@@ -81,13 +76,13 @@ public abstract class S3V4RestSignerClient
private static final String SCOPE = "sign";
@SuppressWarnings("immutables:incompat")
- private static volatile ScheduledExecutorService tokenRefreshExecutor;
+ private volatile AuthManager authManager;
@SuppressWarnings("immutables:incompat")
- private static volatile RESTClient httpClient;
+ private volatile AuthSession authSession;
@SuppressWarnings("immutables:incompat")
- private static volatile Cache<String, AuthSession> authSessionCache;
+ private volatile RESTClient httpClient;
Review Comment:
Yes, this isn't something we can consider a lightweight resource and because
we bind the FileIO to a table, this could result in significant numbers of
instances being created especially in cases where we distribute these
references.
It isn't ideal that there is potential for different property values, but I
would take that risk over the impact of having runaway client creation. The
properties are mostly to configure aspects of the http implementation (I think
only max retries is the only referenced value).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
