nastra commented on code in PR #12197:
URL: https://github.com/apache/iceberg/pull/12197#discussion_r1965346332
##########
aws/src/test/java/org/apache/iceberg/aws/s3/signer/TestS3RestSigner.java:
##########
@@ -86,8 +86,10 @@ public class TestS3RestSigner {
MinioUtil.createContainer(CREDENTIALS_PROVIDER.resolveCredentials());
private static Server httpServer;
- private static ValidatingSigner validatingSigner;
+
+ private ValidatingSigner validatingSigner;
private S3Client s3;
+ private ImmutableS3V4RestSignerClient icebergSigner;
Review Comment:
```suggestion
private S3V4RestSignerClient icebergSigner;
```
##########
gcp/src/main/java/org/apache/iceberg/gcp/gcs/GCSFileIO.java:
##########
@@ -67,6 +67,7 @@ public class GCSFileIO implements DelegateFileIO {
private MetricsContext metrics = MetricsContext.nullMetrics();
private final AtomicBoolean isResourceClosed = new AtomicBoolean(false);
private SerializableMap<String, String> properties = null;
+ private OAuth2RefreshCredentialsHandler handler = null;
Review Comment:
nit: maybe call it `refreshHandler`
##########
aws/src/main/java/org/apache/iceberg/aws/RESTSigV4Signer.java:
##########
@@ -1,157 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied. See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-package org.apache.iceberg.aws;
-
-import java.io.IOException;
-import java.io.UncheckedIOException;
-import java.net.URI;
-import java.net.URISyntaxException;
-import java.util.Arrays;
-import java.util.List;
-import java.util.Map;
-import java.util.stream.Collectors;
-import org.apache.hc.core5.http.EntityDetails;
-import org.apache.hc.core5.http.Header;
-import org.apache.hc.core5.http.HttpHeaders;
-import org.apache.hc.core5.http.HttpRequest;
-import org.apache.hc.core5.http.HttpRequestInterceptor;
-import org.apache.hc.core5.http.io.entity.StringEntity;
-import org.apache.hc.core5.http.protocol.HttpContext;
-import org.apache.iceberg.exceptions.RESTException;
-import software.amazon.awssdk.auth.credentials.AwsCredentialsProvider;
-import software.amazon.awssdk.auth.signer.Aws4Signer;
-import software.amazon.awssdk.auth.signer.internal.SignerConstant;
-import software.amazon.awssdk.auth.signer.params.Aws4SignerParams;
-import software.amazon.awssdk.auth.signer.params.SignerChecksumParams;
-import software.amazon.awssdk.core.checksums.Algorithm;
-import software.amazon.awssdk.http.SdkHttpFullRequest;
-import software.amazon.awssdk.http.SdkHttpMethod;
-import software.amazon.awssdk.regions.Region;
-
-/**
- * Provides a request interceptor for use with the HTTPClient that calculates
the required signature
- * for the SigV4 protocol and adds the necessary headers for all requests
created by the client.
- *
- * <p>See <a
- *
href="https://docs.aws.amazon.com/general/latest/gr/signing-aws-api-requests.html";>Signing
AWS
- * API requests</a> for details about the protocol.
- */
-public class RESTSigV4Signer implements HttpRequestInterceptor {
Review Comment:
yeah I would keep it around and mark the class as deprecated. Even though it
is instantiated via reflection, we actually don't know if other users are using
this in a different way and so it's better to go through the normal deprecation
cycle
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
