adutra commented on code in PR #12197:
URL: https://github.com/apache/iceberg/pull/12197#discussion_r1978906243
##########
aws/src/main/java/org/apache/iceberg/aws/s3/signer/S3V4RestSignerClient.java:
##########
@@ -81,13 +76,13 @@ public abstract class S3V4RestSignerClient
private static final String SCOPE = "sign";
@SuppressWarnings("immutables:incompat")
- private static volatile ScheduledExecutorService tokenRefreshExecutor;
+ private volatile AuthManager authManager;
@SuppressWarnings("immutables:incompat")
- private static volatile RESTClient httpClient;
+ private volatile AuthSession authSession;
@SuppressWarnings("immutables:incompat")
- private static volatile Cache<String, AuthSession> authSessionCache;
+ private volatile RESTClient httpClient;
Review Comment:
Are you sure? I always found this dangerous:
https://github.com/apache/iceberg/blob/be9808fb3d75b1697fc4ed45c02602de9cfb6371/aws/src/main/java/org/apache/iceberg/aws/s3/signer/S3V4RestSignerClient.java#L192-L193
IOW the `HTTPClient` is static, but is built based on instance methods. If
the value returned by `properties()` or by `baseSignerUri()` changes, the
changes won't be reflected in a previously-created `HTTPClient` instance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
