Re: [PR] API, Core: Add deleteFile to RowDelta API [iceberg]

RussellSpitzer commented on PR #12861: URL: https://github.com/apache/iceberg/pull/12861#issuecomment-2855151885 Merging, Thanks for the review @sn2479 , @singhpk234 and @aokolnychyi ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] API, Core: Add deleteFile to RowDelta API [iceberg]

RussellSpitzer merged PR #12861: URL: https://github.com/apache/iceberg/pull/12861 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ic

Re: [PR] API, Core: Add deleteFile to RowDelta API [iceberg]

RussellSpitzer commented on code in PR #12861: URL: https://github.com/apache/iceberg/pull/12861#discussion_r2074205131 ## core/src/main/java/org/apache/iceberg/BaseRowDelta.java: ## @@ -132,15 +144,44 @@ protected void validate(TableMetadata base, Snapshot parent) {

Re: [PR] API, Core: Add deleteFile to RowDelta API [iceberg]

aokolnychyi commented on code in PR #12861: URL: https://github.com/apache/iceberg/pull/12861#discussion_r2074185204 ## core/src/main/java/org/apache/iceberg/BaseRowDelta.java: ## @@ -132,15 +144,44 @@ protected void validate(TableMetadata base, Snapshot parent) {

Re: [PR] API, Core: Add deleteFile to RowDelta API [iceberg]

RussellSpitzer commented on code in PR #12861: URL: https://github.com/apache/iceberg/pull/12861#discussion_r2074117005 ## core/src/main/java/org/apache/iceberg/BaseRowDelta.java: ## @@ -132,15 +144,44 @@ protected void validate(TableMetadata base, Snapshot parent) {

Re: [PR] API, Core: Add deleteFile to RowDelta API [iceberg]

RussellSpitzer commented on code in PR #12861: URL: https://github.com/apache/iceberg/pull/12861#discussion_r2074114731 ## core/src/main/java/org/apache/iceberg/BaseRowDelta.java: ## @@ -132,15 +144,44 @@ protected void validate(TableMetadata base, Snapshot parent) {

Re: [PR] API, Core: Add deleteFile to RowDelta API [iceberg]

RussellSpitzer commented on code in PR #12861: URL: https://github.com/apache/iceberg/pull/12861#discussion_r2074113475 ## core/src/main/java/org/apache/iceberg/BaseRowDelta.java: ## @@ -132,15 +144,44 @@ protected void validate(TableMetadata base, Snapshot parent) {

Re: [PR] API, Core: Add deleteFile to RowDelta API [iceberg]

aokolnychyi commented on code in PR #12861: URL: https://github.com/apache/iceberg/pull/12861#discussion_r2074100873 ## core/src/main/java/org/apache/iceberg/BaseRowDelta.java: ## @@ -132,15 +144,44 @@ protected void validate(TableMetadata base, Snapshot parent) {

Re: [PR] API, Core: Add deleteFile to RowDelta API [iceberg]

aokolnychyi commented on code in PR #12861: URL: https://github.com/apache/iceberg/pull/12861#discussion_r2074096240 ## core/src/main/java/org/apache/iceberg/BaseRowDelta.java: ## @@ -132,15 +144,44 @@ protected void validate(TableMetadata base, Snapshot parent) {

Re: [PR] API, Core: Add deleteFile to RowDelta API [iceberg]

aokolnychyi commented on code in PR #12861: URL: https://github.com/apache/iceberg/pull/12861#discussion_r2074093747 ## core/src/main/java/org/apache/iceberg/BaseRowDelta.java: ## @@ -132,15 +144,44 @@ protected void validate(TableMetadata base, Snapshot parent) {

Re: [PR] API, Core: Add deleteFile to RowDelta API [iceberg]

RussellSpitzer commented on PR #12861: URL: https://github.com/apache/iceberg/pull/12861#issuecomment-2828568406 @aokolnychyi Please take a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] API, Core: Add deleteFile to RowDelta API [iceberg]

RussellSpitzer commented on code in PR #12861: URL: https://github.com/apache/iceberg/pull/12861#discussion_r2054683442 ## core/src/main/java/org/apache/iceberg/BaseRowDelta.java: ## @@ -140,6 +149,11 @@ protected void validate(TableMetadata base, Snapshot parent) { va

Re: [PR] API, Core: Add deleteFile to RowDelta API [iceberg]

RussellSpitzer commented on code in PR #12861: URL: https://github.com/apache/iceberg/pull/12861#discussion_r2054463539 ## core/src/main/java/org/apache/iceberg/BaseRowDelta.java: ## @@ -140,6 +149,11 @@ protected void validate(TableMetadata base, Snapshot parent) { va

Re: [PR] API, Core: Add deleteFile to RowDelta API [iceberg]

singhpk234 commented on code in PR #12861: URL: https://github.com/apache/iceberg/pull/12861#discussion_r2054449713 ## core/src/main/java/org/apache/iceberg/BaseRowDelta.java: ## @@ -140,6 +149,11 @@ protected void validate(TableMetadata base, Snapshot parent) { valida

Re: [PR] API, Core: Add deleteFile to RowDelta API [iceberg]

singhpk234 commented on code in PR #12861: URL: https://github.com/apache/iceberg/pull/12861#discussion_r2054449713 ## core/src/main/java/org/apache/iceberg/BaseRowDelta.java: ## @@ -140,6 +149,11 @@ protected void validate(TableMetadata base, Snapshot parent) { valida

Re: [PR] API, Core: Add deleteFile to RowDelta API [iceberg]

singhpk234 commented on code in PR #12861: URL: https://github.com/apache/iceberg/pull/12861#discussion_r2054449713 ## core/src/main/java/org/apache/iceberg/BaseRowDelta.java: ## @@ -140,6 +149,11 @@ protected void validate(TableMetadata base, Snapshot parent) { valida

Re: [PR] API, Core: Add deleteFile to RowDelta API [iceberg]

singhpk234 commented on code in PR #12861: URL: https://github.com/apache/iceberg/pull/12861#discussion_r2054449713 ## core/src/main/java/org/apache/iceberg/BaseRowDelta.java: ## @@ -140,6 +149,11 @@ protected void validate(TableMetadata base, Snapshot parent) { valida