RussellSpitzer commented on code in PR #12861:
URL: https://github.com/apache/iceberg/pull/12861#discussion_r2054683442
##########
core/src/main/java/org/apache/iceberg/BaseRowDelta.java:
##########
@@ -140,6 +149,11 @@ protected void validate(TableMetadata base, Snapshot
parent) {
validateNoNewDeleteFiles(base, startingSnapshotId,
conflictDetectionFilter, parent);
}
+ if (!deletedDataFiles.isEmpty()) {
+ validateNoNewDeletesForDataFiles(
+ base, startingSnapshotId, conflictDetectionFilter,
deletedDataFiles, parent);
+ }
Review Comment:
I changed this so now you can either use
.validateDeletedFiles() // Checks that paths exist for all deleted files
or
.validateDataFilesExist() // Explictly checking for
I also added a validation that you are not simultaneously deleting a file
while also adding a DeleteFile for that file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
