RussellSpitzer commented on code in PR #12861:
URL: https://github.com/apache/iceberg/pull/12861#discussion_r2074114731
##########
core/src/main/java/org/apache/iceberg/BaseRowDelta.java:
##########
@@ -132,15 +144,44 @@ protected void validate(TableMetadata base, Snapshot
parent) {
parent);
}
+ if (validateDeletes) {
+ failMissingDeletePaths();
+ }
+
if (validateNewDataFiles) {
validateAddedDataFiles(base, startingSnapshotId,
conflictDetectionFilter, parent);
}
if (validateNewDeleteFiles) {
+ // validate that explicitly deleted files have not had added deletes
+ if (!deletedDataFiles.isEmpty()) {
Review Comment:
Yes, our file delete is essentially again being treated as a "position
delete" that effects the entire file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
