RussellSpitzer commented on code in PR #12861:
URL: https://github.com/apache/iceberg/pull/12861#discussion_r2074113475
##########
core/src/main/java/org/apache/iceberg/BaseRowDelta.java:
##########
@@ -132,15 +144,44 @@ protected void validate(TableMetadata base, Snapshot
parent) {
parent);
}
+ if (validateDeletes) {
Review Comment:
Yes, the doc is in RowDelta (although under validateDeletedFiles)
```
/**
* Enable validation that referenced data files passed to {@link
* #validateDataFilesExist(Iterable)} have not been removed by a delete
operation.
*
* <p>If a data file has a row deleted using a position delete file,
rewriting or overwriting the
* data file concurrently would un-delete the row. Deleting the data file
is normally allowed, but
* a delete may be part of a transaction that reads and re-appends a row.
This method is used to
* validate deletes for the transaction case.
*
* @return this for method chaining
*/
```
This usage is similar to adding a position delete for a data file but
instead of removing a singular row we are attempting to remove every row in the
file. The way I have been thinking of this is point deletes and file deletes.
Everything we do for the point deletes we must also do for the file deletes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
