aokolnychyi commented on code in PR #12861:
URL: https://github.com/apache/iceberg/pull/12861#discussion_r2074093747
##########
core/src/main/java/org/apache/iceberg/BaseRowDelta.java:
##########
@@ -132,15 +144,44 @@ protected void validate(TableMetadata base, Snapshot
parent) {
parent);
}
+ if (validateDeletes) {
Review Comment:
If I remember correctly, `validateDeletes` controls whether we check
concurrent `delete` snapshots to see if any of them removed data files that we
include in `referencedDataFiles`. Then `failMissingDeletePaths` must ensure
that whatever we are trying to remove is actually still in the table. In other
words, this blocks means if we do UPDATE or MERGE, make sure that data files
that we are trying to remove entirely are still there.
Correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
