RussellSpitzer commented on code in PR #12861:
URL: https://github.com/apache/iceberg/pull/12861#discussion_r2054463539
##########
core/src/main/java/org/apache/iceberg/BaseRowDelta.java:
##########
@@ -140,6 +149,11 @@ protected void validate(TableMetadata base, Snapshot
parent) {
validateNoNewDeleteFiles(base, startingSnapshotId,
conflictDetectionFilter, parent);
}
+ if (!deletedDataFiles.isEmpty()) {
+ validateNoNewDeletesForDataFiles(
+ base, startingSnapshotId, conflictDetectionFilter,
deletedDataFiles, parent);
+ }
Review Comment:
Hmmm I think it should be implicit here because the removal of files should
be according to the conflict detection filter. I think it should look just like
OverwriteFIles
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
