kevinjqliu commented on code in PR #667:
URL: https://github.com/apache/iceberg-python/pull/667#discussion_r1653273915
##
tests/table/test_snapshots.py:
##
@@ -73,7 +73,7 @@ def test_serialize_snapshot(snapshot: Snapshot) -> None:
)
-def test_serialize_snapshot_without_
HonahX commented on code in PR #667:
URL: https://github.com/apache/iceberg-python/pull/667#discussion_r1650524201
##
pyiceberg/table/snapshots.py:
##
@@ -226,7 +226,8 @@ def __eq__(self, other: Any) -> bool:
class Snapshot(IcebergBaseModel):
snapshot_id: int = Field(alias
syun64 commented on code in PR #667:
URL: https://github.com/apache/iceberg-python/pull/667#discussion_r1588359700
##
pyiceberg/table/metadata.py:
##
@@ -292,6 +292,13 @@ def snapshot_by_name(self, name: str) ->
Optional[Snapshot]:
return self.snapshot_by_id(ref.sn
corleyma commented on code in PR #667:
URL: https://github.com/apache/iceberg-python/pull/667#discussion_r1585505217
##
pyiceberg/table/metadata.py:
##
@@ -292,6 +292,13 @@ def snapshot_by_name(self, name: str) ->
Optional[Snapshot]:
return self.snapshot_by_id(ref.
corleyma commented on code in PR #667:
URL: https://github.com/apache/iceberg-python/pull/667#discussion_r1585505217
##
pyiceberg/table/metadata.py:
##
@@ -292,6 +292,13 @@ def snapshot_by_name(self, name: str) ->
Optional[Snapshot]:
return self.snapshot_by_id(ref.
corleyma commented on code in PR #667:
URL: https://github.com/apache/iceberg-python/pull/667#discussion_r1585505217
##
pyiceberg/table/metadata.py:
##
@@ -292,6 +292,13 @@ def snapshot_by_name(self, name: str) ->
Optional[Snapshot]:
return self.snapshot_by_id(ref.
syun64 commented on code in PR #667:
URL: https://github.com/apache/iceberg-python/pull/667#discussion_r1584763652
##
pyiceberg/table/__init__.py:
##
@@ -3537,6 +3537,39 @@ def update_partitions_map(
schema=table_schema,
)
+def metadata_log_entries(se
syun64 commented on code in PR #667:
URL: https://github.com/apache/iceberg-python/pull/667#discussion_r1584762427
##
pyiceberg/table/snapshots.py:
##
@@ -226,7 +226,8 @@ def __eq__(self, other: Any) -> bool:
class Snapshot(IcebergBaseModel):
snapshot_id: int = Field(alias
kevinjqliu commented on code in PR #667:
URL: https://github.com/apache/iceberg-python/pull/667#discussion_r1584040866
##
pyiceberg/table/metadata.py:
##
@@ -292,6 +292,13 @@ def snapshot_by_name(self, name: str) ->
Optional[Snapshot]:
return self.snapshot_by_id(re
kevinjqliu commented on code in PR #667:
URL: https://github.com/apache/iceberg-python/pull/667#discussion_r1584037066
##
pyiceberg/table/__init__.py:
##
@@ -3537,6 +3537,39 @@ def update_partitions_map(
schema=table_schema,
)
+def metadata_log_entrie
kevinjqliu commented on code in PR #667:
URL: https://github.com/apache/iceberg-python/pull/667#discussion_r1584036888
##
pyiceberg/table/__init__.py:
##
@@ -3537,6 +3537,39 @@ def update_partitions_map(
schema=table_schema,
)
+def metadata_log_entrie
corleyma commented on code in PR #667:
URL: https://github.com/apache/iceberg-python/pull/667#discussion_r1583798006
##
pyiceberg/table/__init__.py:
##
@@ -3537,6 +3537,39 @@ def update_partitions_map(
schema=table_schema,
)
+def metadata_log_entries(
corleyma commented on code in PR #667:
URL: https://github.com/apache/iceberg-python/pull/667#discussion_r1583779367
##
pyiceberg/table/metadata.py:
##
@@ -292,6 +292,13 @@ def snapshot_by_name(self, name: str) ->
Optional[Snapshot]:
return self.snapshot_by_id(ref.
corleyma commented on code in PR #667:
URL: https://github.com/apache/iceberg-python/pull/667#discussion_r1583779367
##
pyiceberg/table/metadata.py:
##
@@ -292,6 +292,13 @@ def snapshot_by_name(self, name: str) ->
Optional[Snapshot]:
return self.snapshot_by_id(ref.
kevinjqliu opened a new pull request, #667:
URL: https://github.com/apache/iceberg-python/pull/667
Resolves #594 (and part of #511)
TODO:
* Add doc in `api.md`
This PR creates a metadata table for "Metadata Log Entries", similar to [its
spark
equivalent](https://iceberg.ap
15 matches
Mail list logo
