syun64 commented on code in PR #667:
URL: https://github.com/apache/iceberg-python/pull/667#discussion_r1584762427
##########
pyiceberg/table/snapshots.py:
##########
@@ -226,7 +226,8 @@ def __eq__(self, other: Any) -> bool:
class Snapshot(IcebergBaseModel):
snapshot_id: int = Field(alias="snapshot-id")
parent_snapshot_id: Optional[int] = Field(alias="parent-snapshot-id",
default=None)
- sequence_number: Optional[int] = Field(alias="sequence-number",
default=None)
+ # cannot import `INITIAL_SEQUENCE_NUMBER` due to circular import
+ sequence_number: Optional[int] = Field(alias="sequence-number", default=0)
Review Comment:
Is there a reason the default value for the sequence number has to be
changed to 0 as opposed to None?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
