syun64 commented on code in PR #667:
URL: https://github.com/apache/iceberg-python/pull/667#discussion_r1588359700
##########
pyiceberg/table/metadata.py:
##########
@@ -292,6 +292,13 @@ def snapshot_by_name(self, name: str) ->
Optional[Snapshot]:
return self.snapshot_by_id(ref.snapshot_id)
return None
+ def _snapshot_as_of_timestamp_ms(self, timestamp_ms: int) ->
Optional[Snapshot]:
Review Comment:
I'm +1 for just supporting `timestamp_ms: int` for now, because it is what
we support consistently across all Iceberg APIs, and as a bonus we don't have
to worry about validating timezone-awareness.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
