corleyma commented on code in PR #667:
URL: https://github.com/apache/iceberg-python/pull/667#discussion_r1585505217
##########
pyiceberg/table/metadata.py:
##########
@@ -292,6 +292,13 @@ def snapshot_by_name(self, name: str) ->
Optional[Snapshot]:
return self.snapshot_by_id(ref.snapshot_id)
return None
+ def _snapshot_as_of_timestamp_ms(self, timestamp_ms: int) ->
Optional[Snapshot]:
Review Comment:
timestamp_ms certainly keeps us closer to the spec, although I could see a
case for some kind of `int | datetime.datetime` interface (maybe requiring
datetimes to be timezone-aware?). Still, it's not exactly hard for callers to
do something like `datatime.now().timestamp()` so I don't know how necessary it
is to work with datetime objects directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
