Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-09-17 Thread via GitHub
nastra commented on PR #9852: URL: https://github.com/apache/iceberg/pull/9852#issuecomment-2354729443 @nqvuong1998 yes that will be shipped with 1.7.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-09-17 Thread via GitHub
nqvuong1998 commented on PR #9852: URL: https://github.com/apache/iceberg/pull/9852#issuecomment-2354712766 Hi @nastra @danielcweeks , Is this pull request scheduled for inclusion in the v1.7 release? -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-09-13 Thread via GitHub
nk1506 commented on PR #9852: URL: https://github.com/apache/iceberg/pull/9852#issuecomment-2349377256 Thanks @nastra and @danielcweeks for your reviews and feedback. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-09-13 Thread via GitHub
nastra merged PR #9852: URL: https://github.com/apache/iceberg/pull/9852 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-09-13 Thread via GitHub
nastra commented on PR #9852: URL: https://github.com/apache/iceberg/pull/9852#issuecomment-2349315113 thanks @nk1506 for your patience here. Also thanks for everyone that helped out with reviews -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[PR] Hive: Add View support for HIVE catalog [iceberg]

2024-09-13 Thread via GitHub
nk1506 opened a new pull request, #9852: URL: https://github.com/apache/iceberg/pull/9852 This changes include: 1. Introduction of common metadata interface(BaseMetadata) for table and view. 2. Refactor for HiveTableOperation to have common code for table and view commits. Ref

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-09-13 Thread via GitHub
nastra closed pull request #9852: Hive: Add View support for HIVE catalog URL: https://github.com/apache/iceberg/pull/9852 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-09-13 Thread via GitHub
nk1506 commented on PR #9852: URL: https://github.com/apache/iceberg/pull/9852#issuecomment-2349077935 Build is failing because of flaky issue https://github.com/apache/iceberg/issues/11046 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-09-13 Thread via GitHub
nastra commented on code in PR #9852: URL: https://github.com/apache/iceberg/pull/9852#discussion_r1758816947 ## hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveViewCommits.java: ## @@ -0,0 +1,472 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-09-13 Thread via GitHub
nastra commented on code in PR #9852: URL: https://github.com/apache/iceberg/pull/9852#discussion_r1758817493 ## hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveViewCommits.java: ## @@ -0,0 +1,472 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-09-13 Thread via GitHub
nastra commented on code in PR #9852: URL: https://github.com/apache/iceberg/pull/9852#discussion_r1758812696 ## hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveViewCommits.java: ## @@ -0,0 +1,472 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-09-13 Thread via GitHub
nastra commented on code in PR #9852: URL: https://github.com/apache/iceberg/pull/9852#discussion_r1758809463 ## hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveViewCommits.java: ## @@ -0,0 +1,472 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-09-13 Thread via GitHub
nastra commented on code in PR #9852: URL: https://github.com/apache/iceberg/pull/9852#discussion_r1758806275 ## hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveViewCommits.java: ## @@ -0,0 +1,472 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-09-13 Thread via GitHub
nk1506 commented on code in PR #9852: URL: https://github.com/apache/iceberg/pull/9852#discussion_r1758592399 ## hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveViewCommits.java: ## @@ -0,0 +1,442 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-09-13 Thread via GitHub
nastra commented on code in PR #9852: URL: https://github.com/apache/iceberg/pull/9852#discussion_r1758509477 ## hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveViewCommits.java: ## @@ -0,0 +1,442 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-09-13 Thread via GitHub
nastra commented on code in PR #9852: URL: https://github.com/apache/iceberg/pull/9852#discussion_r1758507077 ## hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveViewCommits.java: ## @@ -0,0 +1,442 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-09-13 Thread via GitHub
nastra commented on code in PR #9852: URL: https://github.com/apache/iceberg/pull/9852#discussion_r1758492168 ## hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveViewCommits.java: ## @@ -0,0 +1,442 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-09-13 Thread via GitHub
nastra commented on code in PR #9852: URL: https://github.com/apache/iceberg/pull/9852#discussion_r1758473323 ## hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveViewCommits.java: ## @@ -0,0 +1,442 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-09-13 Thread via GitHub
nastra commented on code in PR #9852: URL: https://github.com/apache/iceberg/pull/9852#discussion_r1758471587 ## hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveViewCommits.java: ## @@ -0,0 +1,442 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-09-13 Thread via GitHub
nastra commented on code in PR #9852: URL: https://github.com/apache/iceberg/pull/9852#discussion_r1758468636 ## hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveViewCommits.java: ## @@ -0,0 +1,442 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-09-13 Thread via GitHub
nastra commented on code in PR #9852: URL: https://github.com/apache/iceberg/pull/9852#discussion_r1758467635 ## hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveViewCommits.java: ## @@ -0,0 +1,442 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-09-13 Thread via GitHub
nastra commented on code in PR #9852: URL: https://github.com/apache/iceberg/pull/9852#discussion_r1758464245 ## hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveViewCommits.java: ## @@ -0,0 +1,442 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-09-13 Thread via GitHub
nastra commented on code in PR #9852: URL: https://github.com/apache/iceberg/pull/9852#discussion_r1758457669 ## hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveViewCommits.java: ## @@ -0,0 +1,442 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-09-13 Thread via GitHub
nastra commented on code in PR #9852: URL: https://github.com/apache/iceberg/pull/9852#discussion_r1758455791 ## hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveViewCommits.java: ## @@ -0,0 +1,442 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-09-13 Thread via GitHub
nastra commented on code in PR #9852: URL: https://github.com/apache/iceberg/pull/9852#discussion_r1758455344 ## hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveViewCommits.java: ## @@ -0,0 +1,442 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-09-13 Thread via GitHub
nastra commented on code in PR #9852: URL: https://github.com/apache/iceberg/pull/9852#discussion_r1758453980 ## hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveViewCommits.java: ## @@ -0,0 +1,442 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-09-13 Thread via GitHub
nastra commented on code in PR #9852: URL: https://github.com/apache/iceberg/pull/9852#discussion_r1758427065 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java: ## @@ -229,12 +328,18 @@ private List listIcebergTables( .collect(Collectors.toList())

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-09-13 Thread via GitHub
nk1506 commented on code in PR #9852: URL: https://github.com/apache/iceberg/pull/9852#discussion_r1758368163 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java: ## @@ -229,12 +328,18 @@ private List listIcebergTables( .collect(Collectors.toList())

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-09-13 Thread via GitHub
nastra commented on code in PR #9852: URL: https://github.com/apache/iceberg/pull/9852#discussion_r1758353596 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java: ## @@ -229,12 +328,18 @@ private List listIcebergTables( .collect(Collectors.toList())

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-09-13 Thread via GitHub
nastra commented on code in PR #9852: URL: https://github.com/apache/iceberg/pull/9852#discussion_r1758353596 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java: ## @@ -229,12 +328,18 @@ private List listIcebergTables( .collect(Collectors.toList())

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-09-13 Thread via GitHub
nastra commented on code in PR #9852: URL: https://github.com/apache/iceberg/pull/9852#discussion_r1758346413 ## core/src/main/java/org/apache/iceberg/CatalogUtil.java: ## @@ -137,6 +138,18 @@ public static void dropTableData(FileIO io, TableMetadata metadata) { deleteFile

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-09-13 Thread via GitHub
nastra commented on code in PR #9852: URL: https://github.com/apache/iceberg/pull/9852#discussion_r1758340280 ## core/src/main/java/org/apache/iceberg/CatalogUtil.java: ## @@ -137,6 +138,18 @@ public static void dropTableData(FileIO io, TableMetadata metadata) { deleteFile

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-09-12 Thread via GitHub
danielcweeks commented on PR #9852: URL: https://github.com/apache/iceberg/pull/9852#issuecomment-2347189790 @nk1506 A few comments, but other than that this LGTM @nastra did you also want to take another pass? -- This is an automated message from the Apache Git Service. To respond to t

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-09-12 Thread via GitHub
danielcweeks commented on code in PR #9852: URL: https://github.com/apache/iceberg/pull/9852#discussion_r1757417174 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java: ## @@ -229,12 +328,18 @@ private List listIcebergTables( .collect(Collectors.toL

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-09-12 Thread via GitHub
danielcweeks commented on code in PR #9852: URL: https://github.com/apache/iceberg/pull/9852#discussion_r1757411419 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java: ## @@ -209,11 +262,63 @@ public boolean dropTable(TableIdentifier identifier, boolean pu

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-09-12 Thread via GitHub
danielcweeks commented on code in PR #9852: URL: https://github.com/apache/iceberg/pull/9852#discussion_r1757401294 ## core/src/main/java/org/apache/iceberg/CatalogUtil.java: ## @@ -137,6 +138,18 @@ public static void dropTableData(FileIO io, TableMetadata metadata) { dele

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-08-27 Thread via GitHub
nk1506 commented on PR #9852: URL: https://github.com/apache/iceberg/pull/9852#issuecomment-2313159867 Hi @danielcweeks, Thanks for your feedback. If I recall correctly, @nastra reviewed it and suggested getting additional input from Hive experts. There’s still one open [comment](https://g

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-08-27 Thread via GitHub
danielcweeks commented on PR #9852: URL: https://github.com/apache/iceberg/pull/9852#issuecomment-2313060249 > Hi @nk1506 @danielcweeks Any update for this pull request? It still looks like there's a lot of outstanding comments, so I'm not clear if those comments have been addressed.

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-08-27 Thread via GitHub
nqvuong1998 commented on PR #9852: URL: https://github.com/apache/iceberg/pull/9852#issuecomment-2311919106 Hi @nk1506 @danielcweeks Any update for this pull request? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-07-02 Thread via GitHub
nk1506 commented on PR #9852: URL: https://github.com/apache/iceberg/pull/9852#issuecomment-2189554813 Thanks a lot @szehon-ho . > hi, @nk1506 thanks for ping, ill look at this, but just FYI, when I look a few times back this patch seems a bit far, it adds things like ViewAwareT

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-07-02 Thread via GitHub
szehon-ho commented on PR #9852: URL: https://github.com/apache/iceberg/pull/9852#issuecomment-2189510488 hi, @nk1506 thanks for ping, ill look at this, but just FYI, when I look a few times back this patch seems a bit far, it adds things like ViewAwareTableBuilder and TableAwareViewBuilder

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-04-25 Thread via GitHub
nastra commented on code in PR #9852: URL: https://github.com/apache/iceberg/pull/9852#discussion_r1579326259 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java: ## @@ -209,11 +262,63 @@ public boolean dropTable(TableIdentifier identifier, boolean purge) {

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-04-25 Thread via GitHub
nastra commented on code in PR #9852: URL: https://github.com/apache/iceberg/pull/9852#discussion_r1579323906 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java: ## @@ -209,11 +262,63 @@ public boolean dropTable(TableIdentifier identifier, boolean purge) {

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-04-25 Thread via GitHub
nastra commented on code in PR #9852: URL: https://github.com/apache/iceberg/pull/9852#discussion_r1579292821 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java: ## @@ -209,11 +262,58 @@ public boolean dropTable(TableIdentifier identifier, boolean purge) {

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-04-25 Thread via GitHub
nk1506 commented on code in PR #9852: URL: https://github.com/apache/iceberg/pull/9852#discussion_r1579255109 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java: ## @@ -209,11 +262,63 @@ public boolean dropTable(TableIdentifier identifier, boolean purge) {

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-04-25 Thread via GitHub
nk1506 commented on code in PR #9852: URL: https://github.com/apache/iceberg/pull/9852#discussion_r1579215950 ## hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveViewCommits.java: ## @@ -0,0 +1,437 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-04-25 Thread via GitHub
nk1506 commented on code in PR #9852: URL: https://github.com/apache/iceberg/pull/9852#discussion_r1579198316 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveViewOperations.java: ## @@ -0,0 +1,395 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-04-24 Thread via GitHub
nk1506 commented on code in PR #9852: URL: https://github.com/apache/iceberg/pull/9852#discussion_r1578924531 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveViewOperations.java: ## @@ -0,0 +1,395 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-04-24 Thread via GitHub
nk1506 commented on code in PR #9852: URL: https://github.com/apache/iceberg/pull/9852#discussion_r1578904316 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java: ## @@ -152,6 +173,38 @@ public List listTables(Namespace namespace) { } } + @Overri

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-04-23 Thread via GitHub
nastra commented on code in PR #9852: URL: https://github.com/apache/iceberg/pull/9852#discussion_r1577368517 ## hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveViewCommits.java: ## @@ -0,0 +1,437 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-04-23 Thread via GitHub
nastra commented on code in PR #9852: URL: https://github.com/apache/iceberg/pull/9852#discussion_r1577355581 ## hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveViewCommits.java: ## @@ -0,0 +1,437 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-04-23 Thread via GitHub
nastra commented on code in PR #9852: URL: https://github.com/apache/iceberg/pull/9852#discussion_r1577351385 ## hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveViewCommits.java: ## @@ -0,0 +1,437 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-04-23 Thread via GitHub
nastra commented on code in PR #9852: URL: https://github.com/apache/iceberg/pull/9852#discussion_r1577350170 ## hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveViewCommits.java: ## @@ -0,0 +1,437 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-04-23 Thread via GitHub
nastra commented on code in PR #9852: URL: https://github.com/apache/iceberg/pull/9852#discussion_r1576411506 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java: ## @@ -209,11 +262,63 @@ public boolean dropTable(TableIdentifier identifier, boolean purge) {

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-04-15 Thread via GitHub
nk1506 commented on PR #9852: URL: https://github.com/apache/iceberg/pull/9852#issuecomment-2056983641 Hi @szehon-ho / @pvary / @nastra , Please take a look . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-04-11 Thread via GitHub
nk1506 commented on code in PR #9852: URL: https://github.com/apache/iceberg/pull/9852#discussion_r1560434336 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveViewOperations.java: ## @@ -0,0 +1,386 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-04-10 Thread via GitHub
nk1506 commented on code in PR #9852: URL: https://github.com/apache/iceberg/pull/9852#discussion_r1560477166 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveViewOperations.java: ## @@ -0,0 +1,395 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-04-10 Thread via GitHub
nk1506 commented on code in PR #9852: URL: https://github.com/apache/iceberg/pull/9852#discussion_r1560434336 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveViewOperations.java: ## @@ -0,0 +1,386 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-04-10 Thread via GitHub
nk1506 commented on code in PR #9852: URL: https://github.com/apache/iceberg/pull/9852#discussion_r1560433436 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveViewOperations.java: ## @@ -0,0 +1,386 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-04-10 Thread via GitHub
nk1506 commented on code in PR #9852: URL: https://github.com/apache/iceberg/pull/9852#discussion_r1560432153 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveViewOperations.java: ## @@ -0,0 +1,357 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-04-10 Thread via GitHub
vteja11 commented on code in PR #9852: URL: https://github.com/apache/iceberg/pull/9852#discussion_r1560368628 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveViewOperations.java: ## @@ -0,0 +1,357 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-04-04 Thread via GitHub
nk1506 closed pull request #8907: Hive: Add View support for HIVE catalog URL: https://github.com/apache/iceberg/pull/8907 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-04-04 Thread via GitHub
nk1506 commented on PR #8907: URL: https://github.com/apache/iceberg/pull/8907#issuecomment-2037749273 Closing this PR as same has been addressed with ongoing [PR](https://github.com/apache/iceberg/pull/9852) . -- This is an automated message from the Apache Git Service. To respond to th

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-04-03 Thread via GitHub
nk1506 commented on PR #9852: URL: https://github.com/apache/iceberg/pull/9852#issuecomment-2034389989 @szehon-ho / @nastra , Please let me know if there are any comments left . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-03-28 Thread via GitHub
szehon-ho commented on code in PR #9852: URL: https://github.com/apache/iceberg/pull/9852#discussion_r1544090262 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java: ## @@ -250,29 +368,53 @@ public void renameTable(TableIdentifier from, TableIdentifier orig

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-03-28 Thread via GitHub
szehon-ho commented on code in PR #9852: URL: https://github.com/apache/iceberg/pull/9852#discussion_r1544090262 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java: ## @@ -250,29 +368,53 @@ public void renameTable(TableIdentifier from, TableIdentifier orig

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-03-28 Thread via GitHub
szehon-ho commented on code in PR #9852: URL: https://github.com/apache/iceberg/pull/9852#discussion_r1544090262 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java: ## @@ -250,29 +368,53 @@ public void renameTable(TableIdentifier from, TableIdentifier orig

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-03-28 Thread via GitHub
nastra commented on code in PR #9852: URL: https://github.com/apache/iceberg/pull/9852#discussion_r1542729687 ## hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveViewCatalog.java: ## @@ -0,0 +1,227 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-03-27 Thread via GitHub
nk1506 commented on code in PR #9852: URL: https://github.com/apache/iceberg/pull/9852#discussion_r1542321268 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java: ## @@ -250,29 +368,53 @@ public void renameTable(TableIdentifier from, TableIdentifier origina

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-03-27 Thread via GitHub
nk1506 commented on code in PR #9852: URL: https://github.com/apache/iceberg/pull/9852#discussion_r1541896158 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java: ## @@ -250,29 +368,53 @@ public void renameTable(TableIdentifier from, TableIdentifier origina

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-03-27 Thread via GitHub
nk1506 commented on code in PR #9852: URL: https://github.com/apache/iceberg/pull/9852#discussion_r1541864321 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveViewOperations.java: ## @@ -0,0 +1,351 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-03-27 Thread via GitHub
nk1506 commented on code in PR #9852: URL: https://github.com/apache/iceberg/pull/9852#discussion_r1541864321 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveViewOperations.java: ## @@ -0,0 +1,351 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-03-27 Thread via GitHub
nk1506 commented on code in PR #9852: URL: https://github.com/apache/iceberg/pull/9852#discussion_r1541854460 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveViewOperations.java: ## @@ -0,0 +1,351 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-03-27 Thread via GitHub
szehon-ho commented on code in PR #9852: URL: https://github.com/apache/iceberg/pull/9852#discussion_r1541619872 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveViewOperations.java: ## @@ -0,0 +1,351 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-03-27 Thread via GitHub
szehon-ho commented on code in PR #9852: URL: https://github.com/apache/iceberg/pull/9852#discussion_r1541619023 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveViewOperations.java: ## @@ -0,0 +1,351 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-03-27 Thread via GitHub
szehon-ho commented on code in PR #9852: URL: https://github.com/apache/iceberg/pull/9852#discussion_r1541618026 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveViewOperations.java: ## @@ -0,0 +1,351 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-03-27 Thread via GitHub
szehon-ho commented on code in PR #9852: URL: https://github.com/apache/iceberg/pull/9852#discussion_r1541613871 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java: ## @@ -250,29 +368,53 @@ public void renameTable(TableIdentifier from, TableIdentifier orig

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-03-26 Thread via GitHub
nk1506 commented on code in PR #9852: URL: https://github.com/apache/iceberg/pull/9852#discussion_r1540493957 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java: ## @@ -250,29 +368,53 @@ public void renameTable(TableIdentifier from, TableIdentifier origina

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-03-26 Thread via GitHub
szehon-ho commented on code in PR #9852: URL: https://github.com/apache/iceberg/pull/9852#discussion_r1539932982 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java: ## @@ -250,29 +368,53 @@ public void renameTable(TableIdentifier from, TableIdentifier orig

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-03-26 Thread via GitHub
szehon-ho commented on code in PR #9852: URL: https://github.com/apache/iceberg/pull/9852#discussion_r1539907379 ## core/src/main/java/org/apache/iceberg/BaseMetastoreTableOperations.java: ## @@ -309,65 +304,20 @@ protected enum CommitStatus { * @return Commit Status of Succ

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-03-26 Thread via GitHub
nastra commented on code in PR #9852: URL: https://github.com/apache/iceberg/pull/9852#discussion_r1539276798 ## core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java: ## @@ -59,7 +59,7 @@ public abstract class ViewCatalogTests

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-03-26 Thread via GitHub
nastra commented on code in PR #9852: URL: https://github.com/apache/iceberg/pull/9852#discussion_r1539275723 ## core/src/main/java/org/apache/iceberg/view/ViewMetadata.java: ## @@ -85,6 +85,22 @@ default Integer currentSchemaId() { @Nullable String metadataFileLocation();

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-03-26 Thread via GitHub
nk1506 commented on code in PR #9852: URL: https://github.com/apache/iceberg/pull/9852#discussion_r1538653347 ## core/src/main/java/org/apache/iceberg/BaseMetastoreTableOperations.java: ## @@ -309,65 +304,20 @@ protected enum CommitStatus { * @return Commit Status of Success

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-03-26 Thread via GitHub
nk1506 commented on code in PR #9852: URL: https://github.com/apache/iceberg/pull/9852#discussion_r1539222675 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java: ## @@ -191,6 +191,10 @@ protected void doCommit(TableMetadata base, TableMetadata meta

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-03-26 Thread via GitHub
nk1506 commented on code in PR #9852: URL: https://github.com/apache/iceberg/pull/9852#discussion_r1539216264 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java: ## @@ -113,6 +124,16 @@ public void initialize(String inputName, Map properties) { this.cl

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-03-26 Thread via GitHub
nk1506 commented on code in PR #9852: URL: https://github.com/apache/iceberg/pull/9852#discussion_r1539213080 ## core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java: ## @@ -59,7 +59,7 @@ public abstract class ViewCatalogTestshttps://github.com/apache/iceberg/pull/98

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-03-26 Thread via GitHub
nk1506 commented on code in PR #9852: URL: https://github.com/apache/iceberg/pull/9852#discussion_r1539210409 ## core/src/main/java/org/apache/iceberg/view/ViewMetadata.java: ## @@ -85,6 +85,22 @@ default Integer currentSchemaId() { @Nullable String metadataFileLocation();

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-03-25 Thread via GitHub
nk1506 commented on code in PR #9852: URL: https://github.com/apache/iceberg/pull/9852#discussion_r1538653347 ## core/src/main/java/org/apache/iceberg/BaseMetastoreTableOperations.java: ## @@ -309,65 +304,20 @@ protected enum CommitStatus { * @return Commit Status of Success

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-03-25 Thread via GitHub
szehon-ho commented on code in PR #9852: URL: https://github.com/apache/iceberg/pull/9852#discussion_r1538017237 ## core/src/main/java/org/apache/iceberg/BaseMetastoreTableOperations.java: ## @@ -309,65 +304,20 @@ protected enum CommitStatus { * @return Commit Status of Succ

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-03-25 Thread via GitHub
szehon-ho commented on code in PR #9852: URL: https://github.com/apache/iceberg/pull/9852#discussion_r1538017237 ## core/src/main/java/org/apache/iceberg/BaseMetastoreTableOperations.java: ## @@ -309,65 +304,20 @@ protected enum CommitStatus { * @return Commit Status of Succ

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-03-22 Thread via GitHub
nastra commented on code in PR #9852: URL: https://github.com/apache/iceberg/pull/9852#discussion_r1535409457 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveOperationsBase.java: ## @@ -76,10 +159,10 @@ default boolean exposeInHmsProperties() { return maxHiveTab

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-03-19 Thread via GitHub
nk1506 commented on PR #9852: URL: https://github.com/apache/iceberg/pull/9852#issuecomment-2006601809 This PR is looking meshy with all the refactor changes. I have moved the common code for table view with this new [PR](https://github.com/apache/iceberg/pull/10001) . This PR can go as onl

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-03-18 Thread via GitHub
nastra commented on code in PR #9852: URL: https://github.com/apache/iceberg/pull/9852#discussion_r1528270018 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java: ## @@ -113,6 +124,24 @@ public void initialize(String inputName, Map properties) { this.cl

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-03-18 Thread via GitHub
nastra commented on code in PR #9852: URL: https://github.com/apache/iceberg/pull/9852#discussion_r1528265184 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveOperationsBase.java: ## @@ -181,4 +279,230 @@ default Table newHmsTable(String hmsTableOwner) { return

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-03-18 Thread via GitHub
nk1506 commented on code in PR #9852: URL: https://github.com/apache/iceberg/pull/9852#discussion_r1528257514 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveOperationsBase.java: ## @@ -181,4 +279,230 @@ default Table newHmsTable(String hmsTableOwner) { return

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-03-18 Thread via GitHub
nk1506 commented on code in PR #9852: URL: https://github.com/apache/iceberg/pull/9852#discussion_r1528253765 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveOperationsBase.java: ## @@ -181,4 +279,230 @@ default Table newHmsTable(String hmsTableOwner) { return

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-03-18 Thread via GitHub
nk1506 commented on code in PR #9852: URL: https://github.com/apache/iceberg/pull/9852#discussion_r1528242070 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java: ## @@ -222,53 +231,203 @@ public boolean dropTable(TableIdentifier identifier, boolean purge)

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-03-17 Thread via GitHub
nk1506 commented on code in PR #9852: URL: https://github.com/apache/iceberg/pull/9852#discussion_r1527865180 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java: ## @@ -113,6 +124,24 @@ public void initialize(String inputName, Map properties) { this.cl

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-03-16 Thread via GitHub
nk1506 commented on code in PR #9852: URL: https://github.com/apache/iceberg/pull/9852#discussion_r1527421375 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveViewOperations.java: ## @@ -0,0 +1,216 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-03-16 Thread via GitHub
nk1506 commented on code in PR #9852: URL: https://github.com/apache/iceberg/pull/9852#discussion_r1527420981 ## hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveViewCatalog.java: ## @@ -0,0 +1,165 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

  1   2   3   4   >