nastra commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1758353596
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##########
@@ -229,12 +328,18 @@ private List<TableIdentifier> listIcebergTables(
.collect(Collectors.toList());
}
+ @SuppressWarnings("checkstyle:CyclomaticComplexity")
private void renameTableOrView(
TableIdentifier from,
TableIdentifier originalTo,
HiveOperationsBase.ContentType contentType) {
if (!isValidIdentifier(from)) {
Review Comment:
I agree that using a `Precondition.check` here seems more appropriate but I
just wanted to mention that the original code threw a `NoSuchTableException`
when the identifier was invalid as can be seen in
https://github.com/apache/iceberg/blame/79c88a1775c4e2019fff00de7520826388158424/hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java#L225-L227
so we might need to be careful here in changing the exception being thrown
as I'm not sure whether that would have any implications
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
