szehon-ho commented on PR #9852: URL: https://github.com/apache/iceberg/pull/9852#issuecomment-2189510488
hi, @nk1506 thanks for ping, ill look at this, but just FYI, when I look a few times back this patch seems a bit far, it adds things like ViewAwareTableBuilder and TableAwareViewBuilder that dont make much sense, and it will take some time to think to consider and think if there is a better way. Also, because of the earlier review feedback from @nastra it seems we abandoned the effort to unify metadata class to re-use code from HiveTableOperations that I and @pvary initially proposed . If this is the direction we chose, its ok , but it will take personally some time for me to double check everything, as we are re-implementing all the commit code. Another reviewer may also look at the patch of course, I am just sharing my experience reviewing this one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
