nk1506 commented on PR #9852: URL: https://github.com/apache/iceberg/pull/9852#issuecomment-2313159867
Hi @danielcweeks, Thanks for your feedback. If I recall correctly, @nastra reviewed it and suggested getting additional input from Hive experts. There’s still one open [comment](https://github.com/apache/iceberg/pull/9852#issuecomment-2189510488) related to how we should validate the table/view existence check. Since we plan to use [ViewCatalogTests](https://github.com/apache/iceberg/blob/c95bf58793b3a7ef9b0ffa630b907ce964cd32fe/core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java) with Hive, the expectation is that the error messages are translated in the same way as other catalogs. To achieve this, the PR includes a [helper](https://github.com/apache/iceberg/pull/9852/files#diff-3fdd21d335b598f5354de287be6a8830d78e381c89274f0d6bf85c4c9966b8f0R780) class. Please suggest a better approach to address this comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
