nk1506 commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1539216264
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##########
@@ -113,6 +124,16 @@ public void initialize(String inputName, Map<String,
String> properties) {
this.clients = new CachedClientPool(conf, properties);
}
+ @Override
+ public TableBuilder buildTable(TableIdentifier identifier, Schema schema) {
+ return new ViewAwareTableBuilder(identifier, schema);
Review Comment:
Couldn't find a better way to do the validations with other contents if
exists or not ?This validation should must happen before the refresh operation.
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##########
@@ -113,6 +124,16 @@ public void initialize(String inputName, Map<String,
String> properties) {
this.clients = new CachedClientPool(conf, properties);
}
+ @Override
+ public TableBuilder buildTable(TableIdentifier identifier, Schema schema) {
+ return new ViewAwareTableBuilder(identifier, schema);
+ }
+
+ @Override
+ public ViewBuilder buildView(TableIdentifier identifier) {
+ return new TableAwareViewBuilder(identifier);
Review Comment:
same
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
